Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequenced Bookmarks jump weirdly #456

Open
gpaar opened this issue Nov 7, 2024 · 5 comments
Open

Sequenced Bookmarks jump weirdly #456

gpaar opened this issue Nov 7, 2024 · 5 comments
Assignees
Labels
Bookmarks bug Something isn't working Mars 2020

Comments

@gpaar
Copy link
Collaborator

gpaar commented Nov 7, 2024

See attached pro3d & ann & SB structure and resulting video.
The target when rendered by the batch version is viewed much lower (~20°?) than in the GUI of D:\Setups\PRo3D\4.25.0-prerelease6\PRo3D.Viewer.exe, and some occasional jumps appear.
D:\Setups\PRo3D\4.25.0-prerelease6\PRo3D.Viewer.exe
D:\Setups\PRo3D\4.26.0-prerelease2\PRo3D.Viewer.exe

SB-Jumps.mp4

Hurowitz-Bright-Angel-JJD-JJH.zip
Hurowitz-Bright-Angel-JJD-JJH-WORKS.zip

In Version D:\Setups\PRo3D\4.26.0-prerelease2\PRo3D.Viewer.exe the middle SBs newly defined it works, also without any jumps.
https://github.com/user-attachments/assets/699164fa-0348-410c-9976-488100035088

@gpaar gpaar added bug Something isn't working Mars 2020 Bookmarks labels Nov 7, 2024
@RebeccaNowak
Copy link
Collaborator

@gpaar
Just to clarify: The problem occurs in a scene with existing bookmarks, but if you delete the old bookmarks and create new ones it works again?
So the difference between the two scenes you posted is that the one with the _WORKS suffix ist the one where you replaced bookmarks and it works again?

@gpaar
Copy link
Collaborator Author

gpaar commented Nov 27, 2024

Exactly - I deleted the three misbehaving SBs and inserted new ones, then it worked.
It may be helpful for you to know that the viewing directions reached when clicking on the respective (misbehaving) SB to get it yellow (and the respective flag is on) is DIFFERENT to clicking on its house symbol. This applied only to the misbehaving SBs, for all other SBs the reached position is consistent. Is there an erronous way in which you maintain (redundandly, but in the case of the affected SBs inconsistontly) the view positions / directions?

@RebeccaNowak
Copy link
Collaborator

Thank you for the clarification and the additional information! We only maintain the view once per bookmark, but the fly-to and state change of sbms use different functions, so that's a very good starting point for investigating the problem

@RebeccaNowak
Copy link
Collaborator

The issue seems to be that when creating a smooth path for the fly-to with the (correct) view of the bookmark, the final forward and up vector of the animation are incorrect (all the other parameters are correct). Next step is to investigate why this is happening (especially regarding the difference between the old and newly created bookmarks)

@gpaar
Copy link
Collaborator Author

gpaar commented Nov 28, 2024

Might it be related to removing bookmark N+1, and Bookmark N still remains somehow related to the then removed N+1 and doesn't fit to previous N+2 (or the more so, a newly inserted / re-ordered bookmark M)?
In fact, the smooth transition between bookmarks shall be calculated on the fly, based on the sequence of bookmarks at the time of launching the sequence (in the GUI and as batch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bookmarks bug Something isn't working Mars 2020
Projects
None yet
Development

No branches or pull requests

2 participants