Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_grounded_call doesn't handle absence of slot types properly #14

Open
ulysses4ever opened this issue Mar 27, 2021 · 1 comment
Open
Labels
bug Something isn't working p:low

Comments

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Mar 27, 2021

right now it returns true which is crazy. Should throw an error.

UPD 2023-04-26: perhaps an actionable direction would be to try to reproduce it by removing the following code from is_grounded_call and run the analysis on the packages to see what happens...

    # the following check is taken verbatim from code_warntype
    if !isa(slottypes, Vector{Any})
        return true # I don't know when we get here,
                    # over-approx. as stable
    end
@ulysses4ever ulysses4ever added the bug Something isn't working label Mar 27, 2021
@ulysses4ever ulysses4ever changed the title is_stable_call has no (proper) slot types is_stable_call don't handle absence of slot types properly Mar 27, 2021
@ulysses4ever ulysses4ever changed the title is_stable_call don't handle absence of slot types properly is_grounded_call doesn't handle absence of slot types properly Apr 26, 2023
@ulysses4ever
Copy link
Collaborator Author

Not sure how to repro :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p:low
Projects
None yet
Development

No branches or pull requests

1 participant