Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes being obtained during a disclosure session must be inserted at the bottom of the disclosure selection screen #298

Open
ivard opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ivard
Copy link
Member

ivard commented Nov 22, 2024

In the SessionRepository, there is logic that inserts extra attributes at the position currently selected. This is a legacy feature, as this logic was necessary in the old carousel to ensure that the new choice was inserted at the correct position in the carousel. This is no longer needed.

In the new screen, the additional option should be inserted at the bottom of the list, and the selection should move to the bottom option.

Note: It might be possible to completely remove the remaining logic in the SessionRepository and move it to the DisclosurePermissionBloc. This would centralize all the logic in one place.

Example:

  1. Request: Share your email address.
  2. Screen: Make your choice:
  3. Choose Add an extra email address.
  4. Complete the flow.

The newly added email address must be inserted at the bottom (instead of at the top or the middle).

@DibranMulder DibranMulder added the bug Something isn't working label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants