From f7d62290e71a4e498c9a8236a6c6ef8aae97286f Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Fri, 17 Nov 2023 15:10:39 +0100 Subject: [PATCH 1/2] Fix: background revocation tasks not stopped on close --- CHANGELOG.md | 4 ++++ irmaclient/client.go | 2 ++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f91f7b16..ef87d6ea 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased +### Fixed +- Background revocation tasks not stopped on close + ## [0.14.2] - 2023-10-25 ### Fixed - IRMA session gets stuck in communicating status when user is requested to confirm PIN in `irmaclient` diff --git a/irmaclient/client.go b/irmaclient/client.go index d8554622..a4ebb670 100644 --- a/irmaclient/client.go +++ b/irmaclient/client.go @@ -229,6 +229,8 @@ func New( } func (client *Client) Close() error { + client.PauseJobs() + client.Configuration.Scheduler.Stop() return client.storage.Close() } From e45de253ffbe43b97011ef8d876ab22c453da669 Mon Sep 17 00:00:00 2001 From: Ivar Derksen Date: Wed, 22 Nov 2023 18:29:25 +0100 Subject: [PATCH 2/2] Docs: clarify which component is edited in changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ef87d6ea..d8897660 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased ### Fixed -- Background revocation tasks not stopped on close +- Background revocation tasks not stopped when closing an `irmaclient` ## [0.14.2] - 2023-10-25 ### Fixed