Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_new_best is always false for updates #314

Open
xivh opened this issue Sep 7, 2023 · 0 comments
Open

is_new_best is always false for updates #314

xivh opened this issue Sep 7, 2023 · 0 comments

Comments

@xivh
Copy link
Contributor

xivh commented Sep 7, 2023 •
edited
Loading

If there are conflicting configs during casm update, the one that is chosen does not get "is_new_best" : true in the report. This also happens in update_config_unstable. This means that if you calculate some new configs and they end up mapping back to existing ones, the properties of the existing ones could be updated and you wouldn't know by looking at the reports.

It might also be nice to have a previous_best.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xivh