ci(release): change variable and secret names for release #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Variables changedNo variables changed |
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
added
the
skip changeset
jonrohan
reviewed
Sep 22, 2023
| client-id: ${{ vars.PRIMER_ISSUE_TRIAGE_APP_CLIENT_ID }} | ||
| client-secret: ${{ secrets.PRIMER_ISSUE_TRIAGE_APP_CLIENT_SECRET }} | ||
| installation-id: ${{ vars.PRIMER_ISSUE_TRIAGE_APP_INSTALLATION_ID }} | ||
| app-id: ${{ vars.PPRIMER_APP_CLIENT_ID_SHARED }} |
There was a problem hiding this comment.
Suggested change
| app-id: ${{ vars.PPRIMER_APP_CLIENT_ID_SHARED }} | |
| app-id: ${{ vars.PRIMER_APP_CLIENT_ID_SHARED }} |
|
Thanks! This should already be fixed in main 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an error over at: https://github.com/primer/primitives/actions/runs/6106288510/job/16571101152 in the release workflow where the error indicated that the app id was not provided. This PR is adding in the shared variables and secrets in use in other repos that I think are correct but wanted to double-check with you @camertron to see if there is another set we should be using 👀