Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [a11y] - Breadcrumbs accessibility issues #819

Closed
jjwinskill opened this issue Nov 14, 2024 · 0 comments · Fixed by #833
Closed

🐛 [a11y] - Breadcrumbs accessibility issues #819

jjwinskill opened this issue Nov 14, 2024 · 0 comments · Fixed by #833
Assignees
Labels
brand bug Something isn't working

Comments

@jjwinskill
Copy link

jjwinskill commented Nov 14, 2024

Describe the bug

When a breadcrumb item takes the prop "selected", it is put in a non-interactive state signifying that the breadcrumb item is the same as the active page.

When in this state, a breadcrumb item has no hover state and cannot be clicked. However, it can still be focused and interacted with via keyboard navigation.

Reproduction steps

1. Go to the Storybook implementation of Breadcrumbs at https://primer.style/brand/components/Breadcrumbs
2. Try interacting with the mouse on any bread crumb item in a "selected" state
3. Observe that nothing happens
4. Use the tab key to navigate through the each of the interactive elements, until the Breadcrumb items are reached
5. Using tab, see that the "selected" breadcrumb is focusable
6. When this breadcrumb item is focused, press the enter key to see that it is interactive

Expected behavior

1. Go to the Storybook implementation of Breadcrumbs at https://primer.style/brand/components/Breadcrumbs
2. Try interacting with the mouse on any bread crumb item in a "selected" state
3. Observe that nothing happens
4. Use the tab key to navigate through the each of the interactive elements, until the Breadcrumb items are reached
5. Using tab, see that the "selected" breadcrumb is skipped and is not focusable

Screenshots

Mouse interaction works as expected

Screen.Recording.2024-11-14.at.9.39.51.AM.mov

Keyboard interaction a11y bug

Screen.Recording.2024-11-14.at.9.41.02.AM.mov

Browsers

Chrome

OS

Mac

@jjwinskill jjwinskill added the bug Something isn't working label Nov 14, 2024
@rezrah rezrah added the brand label Nov 18, 2024
@rezrah rezrah self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants