Responsive Image Component #992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AyushRathi07, thanks for contributing! Many of us are out of office for the holidays, but we'll review this the next time our working group meets. |
craigpalermo
added
the
core
|
Sure sir, thanks for letting me know. |
|
👋🏼 @AyushRathi07, thanks for contributing. A few thoughts have been shared w. other authors that we'd just give you a collective feedback, to hopefully, guide the PR to work towards completion. PTAL?
We wonder if you could take a look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team followed TSP and created a new component to display responsive images using srcset. Now, the developers using this design system can use this component to give multiple URLs of images that need to be displayed depending on the viewport size.
Also, the 'rush create' command is missing from your scripts, so we were not able to follow the procedure mentioned in the document but we have thoroughly tested our component for any errors and corrected if found any.