fix(821): Rename size to iconSize in CloseButton #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename the prop and in the component and for the type as well - Update snapshots
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 52 52
Lines 521 521
=========================================
Hits 521 521
Continue to review full report at Codecov.
|
pcln-james
requested changes
Jun 17, 2020
craigpalermo
requested changes
Jun 17, 2020
| title: 'close', | ||
| } | ||
|
|
||
| CloseButton.propTypes = { | ||
| onClick: PropTypes.func, | ||
| size: PropTypes.number, | ||
| iconSize: PropTypes.number, |
There was a problem hiding this comment.
For consistency, I think it'd make sense to keep size, but change it to use the same values as size on Button. Then, we could add iconSize, which would control the size of the icon. However, if we remove size or change it so it no longer accepts a number, I think that would be a breaking change.
|
Closing as we need a better, less break-y way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeprop toiconSizeto prevent type conflicts betweenButtonandCloseButtonCloses #821