Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of icon in Banner component #714

Open
jes708 opened this issue Jan 30, 2020 · 1 comment
Open

Reconsider use of icon in Banner component #714

jes708 opened this issue Jan 30, 2020 · 1 comment
Assignees

Comments

@jes708
Copy link
Collaborator

jes708 commented Jan 30, 2020

Allow icon props, such as size, to be configurable.
Remove presets named after colors, since different palettes will not translate the same
Remove the showIcon prop since there will no longer be presets

https://github.com/priceline/design-system/blob/master/packages/core/src/Banner.js#L89

@craigpalermo
Copy link
Collaborator

Ideas discussed in WG:

  • Might accept Icon as a prop (but this would be a breaking change)
    • Could also be done as an override prop
  • In the meantime, we could just change the color names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants