Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormField has limitation to render children #541

Open
BeniCheni opened this issue Jul 19, 2019 · 1 comment
Open

FormField has limitation to render children #541

BeniCheni opened this issue Jul 19, 2019 · 1 comment

Comments

@BeniCheni
Copy link
Collaborator

BeniCheni commented Jul 19, 2019

FormField has strict requirement of children, which creates limitation to render children w. composition such as the snippet below for a11y.

It'd be nice to improve the support of support to offer a more robust composition w. possibilities.

<FormField>
  <SrOnly>
    <Label>Voice Over</Label>
  </SrOnly>
  <Icon>
  <Select>
    <option>a</option>
  </Select>
<FormField>

Screen Shot 2019-07-18 at 6 46 45 PM

@craigpalermo
Copy link
Collaborator

Discussion notes

Before starting work, we should define a list of allowed child components and a cap on the number of children. We could cap it at 5 children if SrOnly is used, and 4 otherwise.

Proposed allowed children:

  • Label
  • SrOnly
  • Icon
  • Input
  • Select
  • Autocomplete

@BeniCheni BeniCheni removed their assignment Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants