Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PRs don't trigger Chromatic build #1012

Open
craigpalermo opened this issue Feb 8, 2021 · 0 comments
Open

Draft PRs don't trigger Chromatic build #1012

craigpalermo opened this issue Feb 8, 2021 · 0 comments

Comments

@craigpalermo
Copy link
Collaborator

Describe the bug
Draft PRs don't trigger the Chromatic merge check. This feature is useful when devs want to get feedback on WIP changes, but can confuse reviewers if a change isn't actually ready for review.

Affected project(s) (e.g. pcln-design-system, pcln-modal, etc.)
n/a

To Reproduce
Steps to reproduce the behavior:

  1. Open a draft PR

Expected behavior
Draft PRs should run Chromatic build step to generate a static storybook

Screenshots
Screen Shot 2021-02-05 at 3 02 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant