Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#29 community category likes 레포지토리 구현 #30

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Feature/#29 community category likes 레포지토리 구현 #30

merged 4 commits into from
Nov 25, 2024

Conversation

iam52
Copy link
Collaborator

@iam52 iam52 commented Nov 23, 2024

🔓closed #29

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

#29

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지 첨부 가능)

community category likes 레포지토리 구현

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@iam52 iam52 added the feat label Nov 23, 2024
@iam52 iam52 self-assigned this Nov 23, 2024
@iam52 iam52 linked an issue Nov 23, 2024 that may be closed by this pull request
[feat] Community, Category, Likes 레포지토리 구현 #29
Closed
3 tasks
ilgolf
ilgolf reviewed Nov 24, 2024
View reviewed changes
src/main/java/com/mallangs/domain/community/entity/Likes.java Outdated

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long likesId;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳이 엔티티명과 같을 이유 없습니다. like로 가시고 Entity 도 Like로 하고 @table(name = "likes") 로 해결하시죠.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 넵! 수정 하겠습니다

ilgolf
ilgolf reviewed Nov 24, 2024
View reviewed changes
src/main/java/com/mallangs/domain/community/repository/CommunityRepository.java Outdated
public interface CommunityRepository extends JpaRepository<Community, Long> {

// 카테고리별 게시글 목록 조회 (최신순으로 정렬)
@Query("SELECT c FROM Community c " +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"""
SELECT c FROM Community c WHERE ... ORDER BY c.createdAt DESC
"""

형식으로 바꾸시는건 어떨까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 그 형식이 더 보기 좋을 듯 합니다! 감사합니다

Dom1046
Dom1046 approved these changes Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@Dom1046 Dom1046 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굉장히 자세히 레포짜셨네요. 저도 검색 추가해야겠어요.
고생하셨어요.

ilgolf
ilgolf approved these changes Nov 24, 2024
View reviewed changes
Copy link

@ilgolf ilgolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@iam52 iam52 merged commit 1c0e5e2 into develop Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HanJae-Jae HanJae-Jae HanJae-Jae approved these changes

@Dom1046 Dom1046 Dom1046 approved these changes

@ilgolf ilgolf ilgolf approved these changes

Assignees

@iam52 iam52

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Community, Category, Likes 레포지토리 구현
4 participants
@iam52 @ilgolf @Dom1046 @HanJae-Jae