Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] #43 소셜 디자인 #99

Closed
wants to merge 13 commits into from
Closed

[Design] #43 소셜 디자인 #99

wants to merge 13 commits into from
+844 −124

Conversation

shlee9999
Copy link
Collaborator

✅ PR Checklist

  • 불필요한 코드 중복이 없습니다.
  • 민감한 정보를 포함하지 않았습니다.
  • 불필요한 콘솔 로그나 주석을 포함하지 않았습니다.
  • 컴포넌트 key값에 고유한 값을 할당했습니다.

📝 Summary

🔗 ISSUE : #43

🖼️ Screenshots

{BC0C1177-DCCB-4535-B524-EB7FD6FF34B8}

@shlee9999 shlee9999 linked an issue Nov 28, 2024 that may be closed by this pull request
[Design] 소셜 디자인 #43
Open
@github-actions GitHub Actions
Copy link

⚡ Lighthouse Reports

http://localhost:4173/

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.3 s
Largest Contentful Paint 🔴 4.1 s
Total Blocking Time 🟢 160 ms
Cumulative Layout Shift 🟢 0.004
Speed Index 🟢 2.4 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/log

Performance Metrics

Category Score
Performance 🟠 89
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 100

Detailed Metrics

Metric Value
First Contentful Paint 🟢 1.6 s
Largest Contentful Paint 🟠 3.7 s
Total Blocking Time 🟢 10 ms
Cumulative Layout Shift 🟢 0
Speed Index 🟢 1.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/login

Performance Metrics

Category Score
Performance 🟢 92
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 2.6 s
Largest Contentful Paint 🟠 2.8 s
Total Blocking Time 🟢 0 ms
Cumulative Layout Shift 🟢 0.006
Speed Index 🟢 2.6 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

http://localhost:4173/mypage

Performance Metrics

Category Score
Performance 🟠 82
Accessibility 🟢 97
Best Practices 🟢 100
SEO 🟢 92

Detailed Metrics

Metric Value
First Contentful Paint 🟠 1.9 s
Largest Contentful Paint 🔴 4.7 s
Total Blocking Time 🟢 20 ms
Cumulative Layout Shift 🟢 0.001
Speed Index 🟢 1.9 s

Security Checks

Check Status Details
CSP-XSS ⚠️ Ensure CSP is effective against XSS attacks

@shlee9999 shlee9999 closed this Nov 28, 2024
@shlee9999 shlee9999 reopened this Nov 28, 2024
@ruehan
Copy link
Collaborator

ruehan commented Nov 28, 2024

수정할게 많으셨네요 수고하셨습니다!
디자인도 시안대로 잘 구현하신 것 같습니다..!

그런데 브랜치 이름이 한글로 되어있어요

@shlee9999 shlee9999 closed this Nov 28, 2024
@shlee9999 shlee9999 deleted the 43-design-소셜-디자인 branch November 28, 2024 03:50
@shlee9999
Copy link
Collaborator Author

수정했습니다~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruehan ruehan ruehan approved these changes

@kimjuyoung99 kimjuyoung99 Awaiting requested review from kimjuyoung99

@saseungmin saseungmin Awaiting requested review from saseungmin

Assignees

@shlee9999 shlee9999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] 소셜 디자인
2 participants
@shlee9999 @ruehan