Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Fairy Type" interaction with pull #806 #855

Closed
gav-antula opened this issue Oct 15, 2021 · 3 comments
Closed

"Add Fairy Type" interaction with pull #806 #855

gav-antula opened this issue Oct 15, 2021 · 3 comments

Comments

@gav-antula
Copy link

It appears the [ Verify data table sizes with table_width and assert_table_length macros ] ( pull #706 & #806 ) implemented a change that the Fairy Type tutorial in the Wiki doesn't account for. Trying to add a new type (Fairy) led to multiple "Assertion failed" errors. I assume that tutorial should be updated to account for the change?

I'm very new to this so someone else can likely explain it much better than I can, or tell me why I am wrong.

@Rangi42
Copy link
Member

Rangi42 commented Oct 15, 2021

Few if any tutorials spell out the table_width/assert_table_length macros yet. They also don't generally change the table widths though, so all you have to do is notice to add your new data inside the table. The point of the tutorials is to cover updating all the relevant constant and data sequences, so there shouldn't be any failures.

@gav-antula
Copy link
Author

gav-antula commented Oct 15, 2021

Edit: I see about the tutorials, and that makes sense. I think I managed to figure out my original issue with the type count.

Now I'm struggling with the table_length for base_stats.asm: expected 251 entries (but it appears there are 251 entries).

@Idain
Copy link
Contributor

Idain commented Oct 15, 2021

Probably you didn't change a Pokémon's type properly, since ghe amount of entries should still be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants