Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pwsh as pixi shells to the tests and documentation #79

Merged
merged 13 commits into from
Feb 17, 2024

Conversation

ruben-arts
Copy link
Contributor

closes #78

@ruben-arts ruben-arts requested a review from pavelzw as a code owner February 16, 2024 07:24
@ruben-arts ruben-arts marked this pull request as draft February 16, 2024 07:30
@pavelzw
Copy link
Collaborator

pavelzw commented Feb 16, 2024

Or we just don't mention cmd.exe at all for this feature 😅

@ruben-arts ruben-arts marked this pull request as ready for review February 17, 2024 09:02
@ruben-arts
Copy link
Contributor Author

Lets do that @pavelzw, you made my day a little better with that comment.

The jobs that still fail aren't an issue for this pr right?

@pavelzw
Copy link
Collaborator

pavelzw commented Feb 17, 2024

The jobs that still fail aren't an issue for this pr right?

the auth-token-install job is failing because the secret is not leaked to forks.
The Reference latest Pixi version in README job failing can be fixed in this PR :)

README.md Outdated Show resolved Hide resolved
@pavelzw pavelzw added the documentation Improvements or additions to documentation label Feb 17, 2024
```yml
- run: | # everything here will be run inside of the pixi environment
python --version | Select-String "3.11"
shell: pixi run pwsh -Command {0} # pwsh works on all platforms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this even works 🤔 shouldn't it be -File? The thing in {0} will be replaced by a path to the script at runtime...

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with -File but changed to -Command because that is what github uses: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub appends the extension .ps1 to your script name.

interesting... we unfortunately don't have the power to do this :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also change the bash shell to bash -e while we're at it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also find it super weird that there is different bash behavior when specifying bash or not specifying anything on unix...

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah no clue this whole shell thing isn't the most ergonomic feature.

Co-authored-by: Pavel Zwerschke <[email protected]>
@pavelzw pavelzw changed the title Add pwsh and cmd as pixi shells to the test Add pwsh as pixi shells to the test Feb 17, 2024
@pavelzw pavelzw changed the title Add pwsh as pixi shells to the test Add pwsh as pixi shells to the tests and documentation Feb 17, 2024
README.md Show resolved Hide resolved
ruben-arts and others added 2 commits February 17, 2024 10:34
Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pavelzw pavelzw merged commit 20681db into prefix-dev:main Feb 17, 2024
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom shell wrapper doesn't work with powershell
2 participants