-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pwsh
as pixi shells to the tests and documentation
#79
Add pwsh
as pixi shells to the tests and documentation
#79
Conversation
Or we just don't mention |
Lets do that @pavelzw, you made my day a little better with that comment. The jobs that still fail aren't an issue for this pr right? |
the |
```yml | ||
- run: | # everything here will be run inside of the pixi environment | ||
python --version | Select-String "3.11" | ||
shell: pixi run pwsh -Command {0} # pwsh works on all platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started with -File
but changed to -Command
because that is what github uses: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub appends the extension .ps1 to your script name.
interesting... we unfortunately don't have the power to do this :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also change the bash shell to bash -e
while we're at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah no clue this whole shell thing isn't the most ergonomic feature.
Co-authored-by: Pavel Zwerschke <[email protected]>
pwsh
and cmd
as pixi shells to the testpwsh
as pixi shells to the test
pwsh
as pixi shells to the testpwsh
as pixi shells to the tests and documentation
Co-authored-by: Pavel Zwerschke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
closes #78