Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined variables not throwing an error #1240

Open
wolfv opened this issue Dec 7, 2024 · 1 comment
Open

Undefined variables not throwing an error #1240

wolfv opened this issue Dec 7, 2024 · 1 comment

Comments

@wolfv
Copy link
Member

wolfv commented Dec 7, 2024

I think we might want to rethink how we handle undefined variables.

For example, this is not throwing the appropriate Jinja error:

host:
  - ${{ asdasda }}

Instead, it is silently discarded.

@wolfv
Copy link
Member Author

wolfv commented Dec 9, 2024

I looked into it and the issue is that minijinja supports only a mode where undefined values always error when we also want them to error when printing. For this reason, we should also set all non-matching platforms and arch's to false instead of relying on Undefined as falsey value.

I have openend a PR on rattler to be able to iterate through all possible values for Platform and Arch: conda/rattler#972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant