-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local tests fail because pytest doesn't find tests #1167
Comments
I'm also seeing this right now with local builds of scifem on mac-arm64. It appears it's related to Removing I don't think it's right to consider .gitignore at all when computing |
fwiw, I think it's here. The simplest fix is to set that to The most flexible option, I suppose, is to add a |
@minrk I went with parents(false). that never makes sense. Regardnig gitignore in general ... yeah, not sure. It seems like a sensible default. But maybe it's not good. IDK! |
Thanks @rgommers - release is cooking! |
Thanks, that makes sense. I wasn't quite sure how parents(false) is calculated or everywhere CopyDir is used. For source_files, I definitely agree it doesn't make sense because nothing outside the source root should be considered. For recipe files, though, it's a bit different as the recipe is often (usually?) not the root directory of a repo, so considering parents might be required to do the expected thing for the recipe, but not source_files. |
I think even then (for the conda-forge case), the parent gitignore is managed by |
I'm changing the
meson-python
feedstock over torattler-build
in conda-forge/meson-python-feedstock#24. That PR passes just fine, however when running$ rattler-build build --recipe recipe
locally, the test files can't be located:Full output:
The above is on Linux x86-64. It looks like
$SRC_DIR
isn't set during thetests: script:
phase. On macOS arm64 I get a different failure, in the build phase, wherepython
goes missing, probably due to this line in the recipe:recipe.yaml
is auto-converted withconda-recipe-manager
. For the$PYTHON
issue I'm guessing that's a variable set by conda-forge, and perhaps should be dropped during the conversion? The tests failure I don't understand though, the recipe looks pretty much exactly like https://prefix-dev.github.io/rattler-build/latest/testing/#how-tests-are-translated. Any advice?The text was updated successfully, but these errors were encountered: