ROS 1 build failing

[rarmstrong22]

We're attempting to take tofcore_ros out for a spin, but not having much luck. We're stuck back in ROS 1 land, and the build instructions seem to make some pretty big assumptions, like that we're installing ROS from scratch, and that libtofcore is already installed (by make provision_ros1?). Also, there appears to be a typo in ros_nodes/Makefile:

tofcore_ros/ros_nodes/Makefile

Line 51 in 5666045

cd ros1 && source /opt/ros/noetic/setup.bash && colcon build

colcon isn't part of the ROS 1 universe.

I was hoping I would be able to do the typical ROS thing:

• Install a binary libtofcore with rosdep, or if no binaries exist, do a make install to build/install from source.
• Drop tofcore_ros into my ROS workspace and catkin_make.

BTW, nice sensor (Mojave). Looks great so far.

[rarmstrong22]

Circular dependency: on a fresh Ubuntu 20.04 install, make provision_ros1 fails because the provision target needs python3-vcstool package, which we don't have yet, because we get that from the provision_ros1 target. Figured I'd drop this here instead of creating new-ticket spam.