You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm running into a use case where the identity library doesn't fully recognize CloudFormation templates (a superset of YAML/JSON). Rather than clutter the library with relatively niche use-case, I'd rather pass my custom hook all JSON/YAML files and have middleware determine which files to act on.
To that end, I'd like to signal back to pre-commit that the check should be flagged as SKIPPED (rather than passed). I'm proposing a skipped_exit_code parameter to each hook. The idea is that if the hook returns said exit code, it's marked as skipped.
Alternatively - I'm happy to submit a PR to the identity library adding CloudFormation support but I'm not sure it's a good fit and would require a fair amount of work (would need to further parse all JSON/YAML files to determine if they're CFN or not)
Thoughts?
The text was updated successfully, but these errors were encountered:
You didn't answer the second half of my question - which is - do you feel that CloudFormation support in the identity project is a good fit? Would you support a PR to add it?
I'm running into a use case where the
identity
library doesn't fully recognize CloudFormation templates (a superset of YAML/JSON). Rather than clutter the library with relatively niche use-case, I'd rather pass my custom hook all JSON/YAML files and have middleware determine which files to act on.To that end, I'd like to signal back to pre-commit that the check should be flagged as
SKIPPED
(rather than passed). I'm proposing askipped_exit_code
parameter to each hook. The idea is that if the hook returns said exit code, it's marked as skipped.Alternatively - I'm happy to submit a PR to the
identity
library adding CloudFormation support but I'm not sure it's a good fit and would require a fair amount of work (would need to further parse all JSON/YAML files to determine if they're CFN or not)Thoughts?
The text was updated successfully, but these errors were encountered: