You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attributor has a few huge pain points in its exception handling. The biggest offender probably being Attribute#load, who loves to eat errors that come from lazy attribute creation and have nothing to do with the actual loading at hand.
I can think of at least two fixes (both should be done):
add a separate hierarchy of exceptions that specifically does not derive from StandardError for those exceptions that are fatal and a result of a misconfiguration.
rework the myriad Type.load to not rely on exceptions like this one for reporting malformed data: ArgumentError: invalid value for Integer(): "hi"
The text was updated successfully, but these errors were encountered:
Attributor has a few huge pain points in its exception handling. The biggest offender probably being Attribute#load, who loves to eat errors that come from lazy attribute creation and have nothing to do with the actual loading at hand.
I can think of at least two fixes (both should be done):
StandardError
for those exceptions that are fatal and a result of a misconfiguration.Type.load
to not rely on exceptions like this one for reporting malformed data:ArgumentError: invalid value for Integer(): "hi"
The text was updated successfully, but these errors were encountered: