Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink exception handling #62

Open
careo opened this issue Mar 25, 2014 · 1 comment
Open

Rethink exception handling #62

careo opened this issue Mar 25, 2014 · 1 comment
Milestone

Comments

@careo
Copy link
Contributor

careo commented Mar 25, 2014

Attributor has a few huge pain points in its exception handling. The biggest offender probably being Attribute#load, who loves to eat errors that come from lazy attribute creation and have nothing to do with the actual loading at hand.

I can think of at least two fixes (both should be done):

  1. add a separate hierarchy of exceptions that specifically does not derive from StandardError for those exceptions that are fatal and a result of a misconfiguration.
  2. rework the myriad Type.load to not rely on exceptions like this one for reporting malformed data: ArgumentError: invalid value for Integer(): "hi"
@careo careo modified the milestone: v3.0 Sep 15, 2014
@careo
Copy link
Contributor Author

careo commented Nov 2, 2015

This is being reworked as part of praxis/praxis#261.

@careo careo modified the milestones: v4.3, v3.0 Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant