Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should validate build output and conduct function tests before uploading a CRX to the chrome store #178

Open
turbocrime opened this issue Aug 24, 2024 · 1 comment
Labels
ci/cd Deployment and github action related deployment testing

Comments

@turbocrime
Copy link
Contributor

turbocrime commented Aug 24, 2024

Production builds generate different output than development builds. But output of the publish CI is neither verified nor available for inspection before it is published.

To Reproduce

  1. Activate the Prax release workflow.
  2. Good luck!

Expected behavior

The output of the release workflow should have some assurances.

Suggestions

Minimal:

  1. confirm the output zip is not empty.
  2. make the output zip available for download.
  3. check the build for presence of development symbols.
  4. ensure that chrome may install the build output.
  5. ensure that chrome may successfully update from the immediate previous version.

High priority:

  1. ensure onboarding is functional.
  2. ensure that chrome may successfully update from a selection of previous versions.
  3. confirm ability to connect to pd-bundled minifront and latest minifront.

Nice:

  1. Run a suite of integration tests validating native transaction functionality.
  2. Run a suite of integration tests validating ibc functionality.

Ideal:

  1. Confirm behavior when connecting to outdated nodes.
  2. Confirm behavior when connecting to outdated minifront.
  3. Attempt connection to as many frontends as possible.
@turbocrime turbocrime added deployment ci/cd Deployment and github action related testing labels Aug 24, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Aug 24, 2024
@grod220
Copy link
Contributor

grod220 commented Aug 26, 2024

In the extension-upload.yml github action, we can hash the output with the dist attached to the release (will require us doing that). If it doesn't match, it can throw, preventing an upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Deployment and github action related deployment testing
Projects
Status: 🗄️ Backlog
Development

No branches or pull requests

2 participants