Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 504 in case of adding custom schema with no name/type #227

Open
shshashwat opened this issue Oct 7, 2021 · 0 comments · May be fixed by #228
Open

Error 504 in case of adding custom schema with no name/type #227

shshashwat opened this issue Oct 7, 2021 · 0 comments · May be fixed by #228
Assignees
Labels
bug Something isn't working

Comments

@shshashwat
Copy link
Contributor

Problem description
While trying to add a custom schema or json for a given stream, if the name/type which is an optional field not provided the server sends an error 504 after 1 minute which is defalut timeout set by the loadbalancer. This happens as internally this is a required field and in case of protobuf and avro the same value gets populated by reading the schema provided with addSchema request but the same implementation for JSON and Custom is not there. And the code keeps on retying to addSchema as the exception thrown is retriable causing an endless retries till the 504 error is thrown.

Problem location
Add Schema API

Suggestions for an improvement
Add implementation for JSON and Custom schema types as well so that if the required but optional field is not sent with the request, it should be able to parse and use the same way it's doing for Avro and Protobuf types.

@shshashwat shshashwat self-assigned this Oct 7, 2021
@shshashwat shshashwat added the bug Something isn't working label Oct 7, 2021
@shshashwat shshashwat linked a pull request Oct 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant