taiko maps not finishing every once in a while

[chayleaf]

Sometimes the results screen (or a fail) simply won't appear. It's a regression that happened relatively recently (this month?), but I can't exactly tell when.

[bdach]

does this happen on a particular map? if so then please link one.

[chayleaf]

no, it doesn't seem to depend on the map

[chayleaf]

It happened two times in a row when I was playing HD, perhaps HD could be the key to reproducing it more often...

[zachmanthethird]

Yes actually; I'm able to reproduce quite easily on many of the HD tournament maps I've been asked to play. However, it appears to be random as to whether it actually occurs every time. This is also not exclusive to singleplayer, as the top map listed didn't finish in a multiplayer room once. (I was streaming to Twitch at the time)

2022-01-15.01-31-31.mp4

https://osu.ppy.sh/b/389468 Graveyarded - happens extremely frequently
https://osu.ppy.sh/b/1957586 Ranked - happens about 50% of the time
https://osu.ppy.sh/b/3412723 WIP - happens occasionally
https://osu.ppy.sh/b/1410446 Graveyarded - only happened once
The game enters a frozen state where you cannot call any overlays (however they do make feedback audio as if you opened them). I've been able to use debugging windows (Ctrl+F1-3) in this state without any issues. I'll be sure to record the next time it occurs.

[peppy]

Logs would be handy, as we've added a lot more log output since last time they were requested (runtime.log specifically)

[bdach]

thanks for the info above, i have managed to reproduce. much easier when there's something concrete to go off of.

i have a potential fix pending that i will PR if it passes the full test suite.

[bdach]

hopefully #16475 fixes this (if it passes review). i welcome testing of that branch.

[smoogipoo]

Resolved via #16475

[zachmanthethird]

Bad news... it just happened to me again. https://osu.ppy.sh/b/263683 with HR

Interestingly, it does appear to have successfully submitted the score to osu!web but the replay didn't save to the local leaderboard.
network.log.txt | runtime.log.txt

[bdach]

i've tried reproducing on the above map with my usual strategy of putting on +DT,HD,HR,NF and hitting nothing on the entire map (+DT was to just speed up waiting), and didn't manage to reproduce.

however there may be an issue with swell nested object result application because i didn't really look at that properly last time. the map ends with a swell, so that would be my first guess. the other objects shouldn't really have stayed unjudged.

[smoogipoo]

Perhaps this is related to #16757

[chayleaf]

unfortunately, it still happens for me as well, last time it happened on this map https://osu.ppy.sh/beatmapsets/547414#/1159528 with HD and difficulty adjust for OD10.

runtime.log:

2022-02-14 17:07:39 [verbose]: updating selection with beatmap:95886ce7-2f18-4525-985b-d20d788e7997 ruleset:taiko
2022-02-14 17:07:39 [verbose]: beatmap changed from "Tedjimo Yomigy - Lorikeet (yassu-) [Inner Oni]" to "Demetori - Yumeshoushitsu ~ Lost Dream (Nishizumi) [Lost Oni]"
2022-02-14 17:07:39 [verbose]: Game-wide working beatmap updated to Demetori - Yumeshoushitsu ~ Lost Dream (Nishizumi) [Lost Oni]
2022-02-14 17:07:39 [verbose]: Song select working beatmap updated to Demetori - Yumeshoushitsu ~ Lost Dream (Nishizumi) [Lost Oni]
2022-02-14 17:07:42 [verbose]: 📺 OsuScreenStack#236(depth:5) suspended PlaySongSelect#277 (waiting on PlayerLoader#631)
2022-02-14 17:07:42 [verbose]: 📺 OsuScreenStack#236(depth:6) loading PlayerLoader#631
2022-02-14 17:07:42 [verbose]: 📺 OsuScreenStack#236(depth:6) entered PlayerLoader#631
2022-02-14 17:07:44 [verbose]: 📺 OsuScreenStack#236(depth:6) suspended PlayerLoader#631 (waiting on SoloPlayer#238)
2022-02-14 17:07:44 [verbose]: 📺 OsuScreenStack#236(depth:7) entered SoloPlayer#238
2022-02-14 17:08:14 [verbose]: 📺 OsuScreenStack#236(depth:6) exit from SoloPlayer#238
2022-02-14 17:08:14 [verbose]: 📺 OsuScreenStack#236(depth:6) resume to PlayerLoader#631
2022-02-14 17:08:17 [verbose]: 📺 OsuScreenStack#236(depth:6) suspended PlayerLoader#631 (waiting on SoloPlayer#100)
2022-02-14 17:08:17 [verbose]: 📺 OsuScreenStack#236(depth:7) entered SoloPlayer#100
2022-02-14 17:13:47 [verbose]: Chat is now polling every 600000 ms
2022-02-14 17:14:12 [verbose]: Chat is now polling every 60000 ms
2022-02-14 17:14:15 [verbose]: 📺 OsuScreenStack#236(depth:6) exit from SoloPlayer#100
2022-02-14 17:14:15 [verbose]: 📺 OsuScreenStack#236(depth:6) resume to PlayerLoader#631
2022-02-14 17:14:15 [verbose]: 📺 OsuScreenStack#236(depth:5) exit from PlayerLoader#631
2022-02-14 17:14:15 [verbose]: 📺 OsuScreenStack#236(depth:5) resume to PlaySongSelect#277
2022-02-14 17:14:58 [verbose]: Focus contention triggered by BeatmapSetOverlay.
2022-02-14 17:15:11 [verbose]: Focus contention triggered by BeatmapSetOverlay.

network.log:

2022-02-14 17:07:39 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/lookup successfully completed!
2022-02-14 17:07:39 [verbose]: osu.Game.Online.API.Requests.GetBeatmapRequest finished with response size of 2,871 bytes
2022-02-14 17:07:39 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
2022-02-14 17:07:40 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/lookup successfully completed!
2022-02-14 17:07:40 [verbose]: osu.Game.Online.API.Requests.GetBeatmapRequest finished with response size of 2,909 bytes
2022-02-14 17:07:42 [verbose]: Performing request osu.Game.Online.Solo.CreateSoloScoreRequest
2022-02-14 17:07:43 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/1159528/solo/scores successfully completed!
2022-02-14 17:07:43 [verbose]: osu.Game.Online.Solo.CreateSoloScoreRequest finished with response size of 95 bytes
2022-02-14 17:07:53 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:07:54 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:07:54 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:08:14 [verbose]: Performing request osu.Game.Online.Solo.SubmitSoloScoreRequest
2022-02-14 17:08:16 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/1159528/solo/scores/17229355 successfully completed!
2022-02-14 17:08:16 [verbose]: osu.Game.Online.Solo.SubmitSoloScoreRequest finished with response size of 564 bytes
2022-02-14 17:08:16 [verbose]: Performing request osu.Game.Online.Solo.CreateSoloScoreRequest
2022-02-14 17:08:17 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/1159528/solo/scores successfully completed!
2022-02-14 17:08:17 [verbose]: osu.Game.Online.Solo.CreateSoloScoreRequest finished with response size of 95 bytes
2022-02-14 17:08:54 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:08:55 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:08:55 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:09:55 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:09:56 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:09:56 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:10:56 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:10:57 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:10:57 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:11:57 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:11:58 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:11:58 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:12:58 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:12:59 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:12:59 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:14:12 [verbose]: Performing request osu.Game.Online.API.Requests.GetUpdatesRequest
2022-02-14 17:14:13 [verbose]: Request to https://osu.ppy.sh/api/v2/chat/updates successfully completed!
2022-02-14 17:14:13 [verbose]: osu.Game.Online.API.Requests.GetUpdatesRequest finished with response size of 16,737 bytes
2022-02-14 17:14:15 [verbose]: Performing request osu.Game.Online.Solo.SubmitSoloScoreRequest
2022-02-14 17:14:16 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/1159528/solo/scores/17229404 successfully completed!
2022-02-14 17:14:16 [verbose]: osu.Game.Online.Solo.SubmitSoloScoreRequest finished with response size of 570 bytes
2022-02-14 17:14:58 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapSetRequest
2022-02-14 17:14:59 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmapsets/lookup?beatmap_id=1159528 successfully completed!
2022-02-14 17:14:59 [verbose]: osu.Game.Online.API.Requests.GetBeatmapSetRequest finished with response size of 11,091 bytes
2022-02-14 17:14:59 [verbose]: Performing request osu.Game.Online.API.Requests.GetCommentsRequest
2022-02-14 17:14:59 [verbose]: Performing request osu.Game.Online.API.Requests.GetScoresRequest
2022-02-14 17:15:00 [verbose]: Request to https://osu.ppy.sh/api/v2/comments successfully completed!

[chayleaf]

it's also reproducible without HD, at least on this map https://osu.ppy.sh/beatmapsets/1231602#taiko/2560264

now that I think of it, is there a way to record a replay if the map isn't over yet? if there was one, I could just send a replay when this issue occurs again

[bdach]

not currently, no. not even sure if partial replays should be an actual feature, would maybe be debug-only if anything.

[Feodor0090]

Just happened in std. I played with HUD being hidden, without mods, beatmap - https://osu.ppy.sh/beatmapsets/1056140#osu/2297429

The replay was saved normally -
replay.zip

Could this be related to #16753 (results screen just fails to load by some reason)?

Logs were lost due to accidental game opening.

[bdach]

if this was in standard then it's not the same issue. no logs = nothing to work with. if you can't provide a reproduction scenario then we can't investigate.

[zachmanthethird]

It seems extremely rare to find now but crops up every once in a while. https://osu.ppy.sh/b/2983308 in the taiko spotlights playlist C didn't finish, but the score did submit.
Version 2022.327.0 | network.log | runtime.log | Replay file (though rewatching the replay does finish normally)

however there may be an issue with swell nested object result application because i didn't really look at that properly last time. the map ends with a swell, so that would be my first guess. the other objects shouldn't really have stayed unjudged.

Unfortunately rules out that possibility as a definitive answer.
Screenshots during occurrence (couldn't record as still switching to Linux):

[bdach]

i have a small hope that the fix for #17482 may fix these cases too. it's a bit of a long shot though.

[frenzibyte]

I'm slightly confused by those screenshots, is there anything to be taken from the global statistic and textures window screenshots that I'm failing to see, or was that there just to be safe?

[chayleaf]

still reproducible https://www.youtube.com/watch?v=s6aqrNLwRZc&t=6063s
network.log
runtime.log
the logs don't seem useful. I finished this map with HDRDNF 3 times and 2 of those it didn't finish.

[chayleaf]

@bdach I can very consistently reproduce it on this map (I played it with HDRDNF 7 times and it wouldn't finish in any of them). I tried auto and not hitting anything at all but it still finished. With that in mind, if you send me a patch with necessary debug logs added I can probably reproduce it on this map (or you can try doing it yourself)

[chayleaf]

some more info: I added more debug logs, and it turns out 2 objects aren't judged, but all hitobjects specified in the .osu file were judged, will continue debugging

E: Figured it out! It's related to strong hits, they don't get properly judged for some reason

[chayleaf]

should be fixed in #24233