Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading tap_pos (ratio_tap_position1,2,3 and phase_tap_position1,2,3) values for trafo without tap controller #513

Open
AnkurArohi opened this issue Oct 7, 2022 · 0 comments · May be fixed by #887
Labels
bug Something isn't working

Comments

@AnkurArohi
Copy link

AnkurArohi commented Oct 7, 2022

  • Do you want to request a feature or report a bug?
    BUG

  • What is the current behavior?

Currently in the trafos dataframe one can see for the trafos with no tap controller defined, the tap_pos , referring to the columns ratio_tap_position1,2 and phase_tap_position1,2 as default values (-99999), this leads to inconsistency in the interpretation of the dataframe.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
    Simply check the df generated for trafos without any Ratio or phase tap controllers for any trafo ends

  • What is the expected behavior?

Instead of the default value one should post process the dataframe and fiölter out these default values, further replacing them with Nones.
Something like this


df_traf3w=powsybl_net.get_3_windings_transformers()

df_traf3w.query("ratio_tap_position1 == -99999").replace(-99999,None)

Obviously then we still need an update statement to update the dataframe I am not aware of a faster more performant alternative.

  • What is the motivation / use case for changing the behavior?

Data consistency

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@AnkurArohi AnkurArohi added the bug Something isn't working label Oct 7, 2022
@AnkurArohi AnkurArohi changed the title Misleading tap_pos (ratio_tap_position1,2 and phase_tap_position1,2) values for trafo without tap controller Misleading tap_pos (ratio_tap_position1,2,3 and phase_tap_position1,2,3) values for trafo without tap controller Oct 7, 2022
@AnkurArohi AnkurArohi linked a pull request Nov 7, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant