You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The slurm computation manager has integration tests, but the pure unit tests could cover a larger part of the code.
What is the expected behavior?
We could increase the coverage on some parts:
flag files monitor
scontrol monitor
general task management behaviour (cancels etc.)
This will require to mock some inner used components (file system, command runner), and maybe to design another inner interface which would encapsulate closely the interactions with slurm.
What is the motivation / use case for changing the behavior?
Robustness, and "auto-documentation".
For example, the flag files monitor behaviour could be illustrated with simple unit tests.
Please tell us about your environment:
PowSyBl Version: ...
OS Version: ...
The text was updated successfully, but these errors were encountered:
Quality improvement.
The slurm computation manager has integration tests, but the pure unit tests could cover a larger part of the code.
We could increase the coverage on some parts:
flag files monitor
scontrol monitor
general task management behaviour (cancels etc.)
This will require to mock some inner used components (file system, command runner), and maybe to design another inner interface which would encapsulate closely the interactions with slurm.
What is the motivation / use case for changing the behavior?
Robustness, and "auto-documentation".
For example, the flag files monitor behaviour could be illustrated with simple unit tests.
The text was updated successfully, but these errors were encountered: