-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getSpecificParameters
methods for analyses providers
#3175
Comments
I was thinking of a common interface for computation providers to avoid similar problems in the future. There is a lot in common but also some differences:
Giving this, I would suggest a common interface for all computation providers mentioned (SpecificParametersProvider?) to also add other missing methods.
and it looks like we often either need the class or name for specific parameters but I haven't checked where these methods are used/if it's meaningful for all providers:
It would make the code more consistent for all the providers. |
Describe the current behavior
The following providers have methods allowing to retrieve the specific parameters' description:
LoadFlowProvider
ShortCircuitAnalysisProvider
Describe the expected behavior
The other providers could also expose methods allowing to retrieve this description:
SecurityAnalysisProvider
SensitivityAnalysisProvider
And maybe:
DynamicSecurityAnalysisProvider
DynamicSimulationProvider
(These need to be checked.)
Describe the motivation
For now, the motivation is only to have consistency between the providers.
Extra Information
The methods to add are:
List<Parameter> getSpecificParameters()
List<Parameter> getSpecificParameters(PlatformConfig platformConfigConfig)
The text was updated successfully, but these errors were encountered: