Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES functional logs #3140

Closed
nemanja-st opened this issue Sep 16, 2024 · 2 comments
Closed

CGMES functional logs #3140

nemanja-st opened this issue Sep 16, 2024 · 2 comments

Comments

@nemanja-st
Copy link
Contributor

Describe the current behavior

CGMES doesn't have detailed functional logs when setting values or for developer purpose.

Describe the expected behavior

CGMES import/export should have more detailed logs when:

  • setting default values when value is missing
  • changing values because they're invalid
  • any other reason that's determined during the implementation

Describe the motivation

Detailed logs are needed to inform the user about the changes that are being made in the model, but also to document the developers intent in more detail, without having to browse through the code or github issue/PR.

Extra Information

No response

@So-Fras
Copy link
Member

So-Fras commented Jan 16, 2025

@nemanja-st did you have a chance to check the PR #3161? Can I close this issue?

@nemanja-st
Copy link
Contributor Author

nemanja-st commented Jan 16, 2025

@nemanja-st did you have a chance to check the PR #3161? Can I close this issue?

Hello @So-Fras , I briefly checked the PR and it looks ok for log starting.
Since I don't have the capacity to work on the issue, you can close it.

@So-Fras So-Fras closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants