Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cloud connection network attach resource and documentation #61

Closed
wants to merge 2 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@@ -29,6 +29,7 @@ const (
Arg_VolumeGroupID = "pi_volume_group_id"
Arg_VolumeID = "pi_volume_id"
Arg_VolumeOnboardingID = "pi_volume_onboarding_id"
Arg_CloudConnectionID = "pi_cloud_connection_id"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be around the top of the file

)

const (
PICloudConnectionNetworkId = "pi_network_id"
Arg_CloudConnectionNetworkId = "pi_network_id"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be moved to the const file

@michaelkad
Copy link
Collaborator

Opened #127

@michaelkad michaelkad closed this May 28, 2024
@michaelkad michaelkad deleted the cloud-network-attach branch September 6, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants