forked from IBM-Cloud/terraform-provider-ibm
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Diff User Tags #175
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkad
force-pushed
the
power-user-tags
branch
from
November 13, 2024 15:13
7987fff
to
f4395bf
Compare
Alexander-Kita
previously approved these changes
Nov 14, 2024
Approved, but should we add this to each resource with pi_user_tags in this same PR since it is a similar change in each? |
I am cool with that. If it's a find and replace change, I'm ok with it being in the same PR. |
michaelkad
force-pushed
the
power-user-tags
branch
2 times, most recently
from
November 18, 2024 22:33
2819e14
to
ad7d899
Compare
ismirlia
previously approved these changes
Nov 18, 2024
Alexander-Kita
previously approved these changes
Nov 20, 2024
Alexander-Kita
dismissed
their stale review
November 20, 2024 15:41
Will talk about computed on unset tags
michaelkad
force-pushed
the
power-user-tags
branch
from
December 2, 2024 21:57
ad7d899
to
dbda1bc
Compare
Alexander-Kita
previously approved these changes
Dec 2, 2024
Approved, but fix conflicts. |
ismirlia
previously approved these changes
Dec 2, 2024
Add compute to tag Add compute to tag, batch2 Remove custom diff
michaelkad
dismissed stale reviews from ismirlia and Alexander-Kita
via
December 3, 2024 22:57
8f5cdcb
michaelkad
force-pushed
the
power-user-tags
branch
from
December 3, 2024 22:57
dbda1bc
to
8f5cdcb
Compare
ismirlia
approved these changes
Dec 3, 2024
open in main repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: