Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Diff User Tags #175

Closed
wants to merge 1 commit into from
Closed

Custom Diff User Tags #175

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

@michaelkad michaelkad commented Oct 28, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPICaptureUserTags
--- PASS: TestAccIBMPICaptureUserTags (204.92s)
PASS

=== RUN   TestAccIBMPIImageUserTags
--- PASS: TestAccIBMPIImageUserTags (123.24s)
PASS

=== RUN   TestAccIBMPIInstanceUserTags
--- PASS: TestAccIBMPIInstanceUserTags (956.58s)
PASS

=== RUN   TestAccIBMPINetworkUserTags
--- PASS: TestAccIBMPINetworkUserTags (76.79s)
PASS

=== RUN   TestAccIBMPINetworkAddressGroupBasic
--- PASS: TestAccIBMPINetworkAddressGroupBasic (34.86s)
PASS

=== RUN   TestAccIBMPINetworkInterfaceBasic
--- PASS: TestAccIBMPINetworkInterfaceBasic (31.60s)
PASS

=== RUN   TestAccIBMPISPPUserTags
--- PASS: TestAccIBMPISPPUserTags (204.37s)
PASS

=== RUN   TestAccIBMPIInstanceSnapshotUserTags
--- PASS: TestAccIBMPIInstanceSnapshotUserTags (930.61s)
PASS

=== RUN   TestAccIBMPIVolumeUserTags
--- PASS: TestAccIBMPIVolumeUserTags (92.77s)
PASS

=== RUN   TestAccIBMPIWorkspaceUserTags
--- PASS: TestAccIBMPIWorkspaceUserTags (183.66s)
PASS
...

@michaelkad michaelkad marked this pull request as ready for review November 13, 2024 15:08
Alexander-Kita
Alexander-Kita previously approved these changes Nov 14, 2024
@Alexander-Kita
Copy link
Collaborator

Approved, but should we add this to each resource with pi_user_tags in this same PR since it is a similar change in each?

@ismirlia
Copy link
Collaborator

I am cool with that. If it's a find and replace change, I'm ok with it being in the same PR.

ismirlia
ismirlia previously approved these changes Nov 18, 2024
Alexander-Kita
Alexander-Kita previously approved these changes Nov 20, 2024
@Alexander-Kita Alexander-Kita dismissed their stale review November 20, 2024 15:41

Will talk about computed on unset tags

Alexander-Kita
Alexander-Kita previously approved these changes Dec 2, 2024
@Alexander-Kita
Copy link
Collaborator

Approved, but fix conflicts.

ismirlia
ismirlia previously approved these changes Dec 2, 2024
@ismirlia ismirlia added the Q4 label Dec 3, 2024
Add compute to tag
Add compute to tag, batch2

Remove custom diff
@michaelkad
Copy link
Collaborator Author

open in main repo

@michaelkad michaelkad closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants