Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Granular CRN for dedicated host resources and data sources #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Granular CRN for dedicated host resources and data sources #165

wants to merge 1 commit into from

Conversation

Alexander-Kita
Copy link
Collaborator

@Alexander-Kita Alexander-Kita commented Aug 20, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_host (r)

=== RUN   TestAccIBMIHostBasic
--- PASS: TestAccIBMIHostBasic (77.36s)
PASS

=== RUN   TestAccIBMIHostUserTags
--- PASS: TestAccIBMIHostUserTags (109.45s)
PASS

pi_host_group (r)

=== RUN   TestAccIBMPIHostGroupBasic
--- PASS: TestAccIBMPIHostGroupBasic (66.91s)
PASS

pi_host (d)

=== RUN   TestAccIBMPIHostDataSourceBasic
--- PASS: TestAccIBMPIHostDataSourceBasic (40.21s)
PASS

pi_hosts (d)

=== RUN   TestAccIBMPIHostsDataSourceBasic
--- PASS: TestAccIBMPIHostsDataSourceBasic (43.91s)
PASS

@Alexander-Kita Alexander-Kita self-assigned this Aug 20, 2024
michaelkad
michaelkad requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@michaelkad michaelkad added the Q3 label Sep 13, 2024
@ismirlia ismirlia added Q4 and removed Q3 labels Sep 23, 2024
@Alexander-Kita Alexander-Kita force-pushed the crn-hosts branch 3 times, most recently from 2c37daa to e6e8459 Compare October 2, 2024 19:05
@Alexander-Kita Alexander-Kita force-pushed the crn-hosts branch 3 times, most recently from f2e2e32 to ba6ca9e Compare October 21, 2024 17:10
ismirlia
ismirlia previously approved these changes Oct 31, 2024
View reviewed changes
@Alexander-Kita Alexander-Kita force-pushed the crn-hosts branch 3 times, most recently from ff8f396 to d20d6ac Compare November 7, 2024 15:06
@Alexander-Kita Alexander-Kita force-pushed the crn-hosts branch 2 times, most recently from 7a8cab2 to 5bd14aa Compare November 18, 2024 16:27
@Alexander-Kita Alexander-Kita marked this pull request as ready for review November 18, 2024 16:27
@Alexander-Kita Alexander-Kita marked this pull request as draft November 18, 2024 17:32
@Alexander-Kita Alexander-Kita marked this pull request as ready for review November 18, 2024 18:44
michaelkad
michaelkad previously approved these changes Nov 18, 2024
View reviewed changes
@Alexander-Kita Alexander-Kita removed the Q4 label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad left review comments

@ismirlia ismirlia Awaiting requested review from ismirlia

At least 1 approving review is required to merge this pull request.

Assignees

@Alexander-Kita Alexander-Kita

Labels
Datasource Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @michaelkad @ismirlia