Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Volume Group Action #135

Closed
wants to merge 1 commit into from
Closed

[Refactor] Volume Group Action #135

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@michaelkad michaelkad mentioned this pull request May 31, 2024
Closed
@ismirlia
Copy link
Collaborator

ismirlia commented Jul 1, 2024 •
edited
Loading 

VolumeGroup Action Test
--- PASS: TestAccIBMPIVolumeGroupActionbasic (398.17s)
PASS

Requires: #134 code merged first though

@ismirlia ismirlia marked this pull request as ready for review July 1, 2024 21:13
Alexander-Kita
Alexander-Kita previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@Alexander-Kita Alexander-Kita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but fix conflicts before moving over.

@Alexander-Kita Alexander-Kita dismissed their stale review November 6, 2024 20:41

Found changes needed

@ismirlia ismirlia force-pushed the volume-group-action-refactor branch from f596a0d to a5c960b Compare November 6, 2024 22:16
@ismirlia
Copy link
Collaborator

ismirlia commented Nov 8, 2024

Opened: IBM-Cloud#5780 closing this one.

@ismirlia ismirlia closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia left review comments

@Alexander-Kita Alexander-Kita Alexander-Kita approved these changes

Assignees
No one assigned
Labels
Refactor Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @ismirlia @Alexander-Kita