Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CC Network Attach #127

Closed
wants to merge 1 commit into from
Closed

Refactor CC Network Attach #127

wants to merge 1 commit into from

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@michaelkad michaelkad mentioned this pull request May 28, 2024
Closed
@ismirlia
Copy link
Collaborator 

--- PASS: TestAccIBMPICloudConnectionNetworkAttachBasic (336.50s)
PASS

@ismirlia ismirlia marked this pull request as ready for review July 15, 2024 18:38
@ismirlia ismirlia force-pushed the cc-network-attach-refactor branch from 34bdf5b to cbeacd5 Compare November 7, 2024 17:33
@ismirlia
Copy link
Collaborator

ismirlia commented Nov 15, 2024 •
edited
Loading

Opening IBM-Cloud#5781, closing this one.

@ismirlia ismirlia closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia left review comments

@Alexander-Kita Alexander-Kita Alexander-Kita approved these changes

Assignees
No one assigned
Labels
Refactor Resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkad @ismirlia @Alexander-Kita