From 2c42ef5b679a25a5b84f65af5860290c6ca1c493 Mon Sep 17 00:00:00 2001 From: Psionik K <73710933+psionic-k@users.noreply.github.com> Date: Mon, 23 Oct 2023 07:27:56 -0500 Subject: [PATCH] Support for external templates ERK is no longer a good demonstration project because it's getting too big. This also makes string replacement hard because if your derivative needs to retain instructions about using ERK, the clones get strings replaced that were needed for the instructions. Implementation was done by creating a template system and pointing it towards erk-basic, a stripped down ERK project with just one command and one test. Licenses are a bit annoying in this release. I want to go ahead and switch to a proper license package and take the licenses out of the templates. For now, the license had to be added to the erk-basic in order to maintain rough parity. Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com> --- .github/run-shim.el | 2 +- docs/README.org | 3 + docs/manual.org | 30 +- gpl-3.0.txt | 674 -------------------------------------------- lisp/erk.el | 470 ++++++++++++++++++------------ test/erk-test.el | 77 ++++- 6 files changed, 373 insertions(+), 883 deletions(-) delete mode 100644 gpl-3.0.txt diff --git a/.github/run-shim.el b/.github/run-shim.el index a0c3ed8..cab6764 100644 --- a/.github/run-shim.el +++ b/.github/run-shim.el @@ -2,7 +2,7 @@ ;; Copyright (C) 2022 Positron Solutions -;; Author: +;; Author: Positron Solutions ;; Permission is hereby granted, free of charge, to any person obtaining a copy of ;; this software and associated documentation files (the "Software"), to deal in diff --git a/docs/README.org b/docs/README.org index b19b1cb..bcd6b15 100644 --- a/docs/README.org +++ b/docs/README.org @@ -13,6 +13,9 @@ #+end_export * Elisp Repo Kit + :PROPERTIES: + :UNNUMBERED: notoc + :END: This repository is a kit to start a new elisp package repository on GitHub. The package contained has commands to streamline elisp development. diff --git a/docs/manual.org b/docs/manual.org index b5765a5..b4dfe18 100644 --- a/docs/manual.org +++ b/docs/manual.org @@ -37,8 +37,8 @@ working with Elisp packages, Elisp Repo Kit provides shortcuts: * High Level Overview - - As a repository, Elisp Repo Kit is a template for how to organize and - distribute your project. + - Elisp Repo Kit provides a scheme for how to organize and distribute your + project, which it also uses in its own repository. - As an Elisp package, Elisp Repo Kit (erk) provides shortcuts for working on package using the Elisp Repo Kit organization structure (as well as other @@ -134,13 +134,10 @@ working with Elisp packages, Elisp Repo Kit provides shortcuts: #+findex: erk-clone The standalone command, ~erk-clone~ will clone without renaming. - This repo is also a [[https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-repository-from-a-template][template repository]], so you can fork without forking - (Bruce Lee). - #+findex: erk-rename - If you create via template or clone manually, it's presumed you know what - you're doing at that point. Call ~erk-rename~ on its own to rename - in these cases. + If you create via [[https://github.com/positron-solutions/erk-basic][a template]] or clone manually, it's presumed you know what + you're doing at that point. Call ~erk-rename~ on its own to rename in these + cases. There are some customize options that cause the renaming to be transitively consistent. @@ -156,12 +153,14 @@ working with Elisp packages, Elisp Repo Kit provides shortcuts: The simplest and intended way is to call ~erk-new~. It will first ask you for: + - Choose a template - Root directory you want to clone to - - Package name + - Package title + - Package feature - Package prefix - Author name - - GitHub user or organization - Email address + - GitHub user or organization #+findex: erk-rename-relicense ~erk-new~ also calls ~erk-rename-relicense~ to rename all of the files, string @@ -482,11 +481,12 @@ overview: will want this information in your new repository. ** Licensing, Developer Certificate of Origin - This template project is distributed with the MIT license. ~erk-new~ will also - run ~erk-rename-relicense~, which will automatically switch to the GPL3 - license. *The MIT license allows re-licensing, and so this change is - compatible.* If you accept non-trivial changes to your project, it will be - very hard to change to the GPL3 later, so consider this choice. + This project and its derivative templates are distributed with an MIT + license. ~erk-new~ will also run ~erk-rename-relicense~, which will + automatically switch to the GPL3 license. *The MIT license allows + re-licensing, and so this change is compatible.* If you accept non-trivial + changes to your project, it will be very hard to change to the GPL3 later, so + consider this choice. The new repository will also come with DCO sign-off checking on PR's. The instructions are in the [[../CONTRIBUTING.md][CONTRIBUTING]] guide. A DCO sign-off policy will give diff --git a/gpl-3.0.txt b/gpl-3.0.txt deleted file mode 100644 index f288702..0000000 --- a/gpl-3.0.txt +++ /dev/null @@ -1,674 +0,0 @@ - GNU GENERAL PUBLIC LICENSE - Version 3, 29 June 2007 - - Copyright (C) 2007 Free Software Foundation, Inc. - Everyone is permitted to copy and distribute verbatim copies - of this license document, but changing it is not allowed. - - Preamble - - The GNU General Public License is a free, copyleft license for -software and other kinds of works. - - The licenses for most software and other practical works are designed -to take away your freedom to share and change the works. By contrast, -the GNU General Public License is intended to guarantee your freedom to -share and change all versions of a program--to make sure it remains free -software for all its users. We, the Free Software Foundation, use the -GNU General Public License for most of our software; it applies also to -any other work released this way by its authors. You can apply it to -your programs, too. - - When we speak of free software, we are referring to freedom, not -price. Our General Public Licenses are designed to make sure that you -have the freedom to distribute copies of free software (and charge for -them if you wish), that you receive source code or can get it if you -want it, that you can change the software or use pieces of it in new -free programs, and that you know you can do these things. - - To protect your rights, we need to prevent others from denying you -these rights or asking you to surrender the rights. Therefore, you have -certain responsibilities if you distribute copies of the software, or if -you modify it: responsibilities to respect the freedom of others. - - For example, if you distribute copies of such a program, whether -gratis or for a fee, you must pass on to the recipients the same -freedoms that you received. You must make sure that they, too, receive -or can get the source code. And you must show them these terms so they -know their rights. - - Developers that use the GNU GPL protect your rights with two steps: -(1) assert copyright on the software, and (2) offer you this License -giving you legal permission to copy, distribute and/or modify it. - - For the developers' and authors' protection, the GPL clearly explains -that there is no warranty for this free software. For both users' and -authors' sake, the GPL requires that modified versions be marked as -changed, so that their problems will not be attributed erroneously to -authors of previous versions. - - Some devices are designed to deny users access to install or run -modified versions of the software inside them, although the manufacturer -can do so. This is fundamentally incompatible with the aim of -protecting users' freedom to change the software. The systematic -pattern of such abuse occurs in the area of products for individuals to -use, which is precisely where it is most unacceptable. Therefore, we -have designed this version of the GPL to prohibit the practice for those -products. If such problems arise substantially in other domains, we -stand ready to extend this provision to those domains in future versions -of the GPL, as needed to protect the freedom of users. - - Finally, every program is threatened constantly by software patents. -States should not allow patents to restrict development and use of -software on general-purpose computers, but in those that do, we wish to -avoid the special danger that patents applied to a free program could -make it effectively proprietary. To prevent this, the GPL assures that -patents cannot be used to render the program non-free. - - The precise terms and conditions for copying, distribution and -modification follow. - - TERMS AND CONDITIONS - - 0. Definitions. - - "This License" refers to version 3 of the GNU General Public License. - - "Copyright" also means copyright-like laws that apply to other kinds of -works, such as semiconductor masks. - - "The Program" refers to any copyrightable work licensed under this -License. Each licensee is addressed as "you". "Licensees" and -"recipients" may be individuals or organizations. - - To "modify" a work means to copy from or adapt all or part of the work -in a fashion requiring copyright permission, other than the making of an -exact copy. The resulting work is called a "modified version" of the -earlier work or a work "based on" the earlier work. - - A "covered work" means either the unmodified Program or a work based -on the Program. - - To "propagate" a work means to do anything with it that, without -permission, would make you directly or secondarily liable for -infringement under applicable copyright law, except executing it on a -computer or modifying a private copy. Propagation includes copying, -distribution (with or without modification), making available to the -public, and in some countries other activities as well. - - To "convey" a work means any kind of propagation that enables other -parties to make or receive copies. Mere interaction with a user through -a computer network, with no transfer of a copy, is not conveying. - - An interactive user interface displays "Appropriate Legal Notices" -to the extent that it includes a convenient and prominently visible -feature that (1) displays an appropriate copyright notice, and (2) -tells the user that there is no warranty for the work (except to the -extent that warranties are provided), that licensees may convey the -work under this License, and how to view a copy of this License. If -the interface presents a list of user commands or options, such as a -menu, a prominent item in the list meets this criterion. - - 1. Source Code. - - The "source code" for a work means the preferred form of the work -for making modifications to it. "Object code" means any non-source -form of a work. - - A "Standard Interface" means an interface that either is an official -standard defined by a recognized standards body, or, in the case of -interfaces specified for a particular programming language, one that -is widely used among developers working in that language. - - The "System Libraries" of an executable work include anything, other -than the work as a whole, that (a) is included in the normal form of -packaging a Major Component, but which is not part of that Major -Component, and (b) serves only to enable use of the work with that -Major Component, or to implement a Standard Interface for which an -implementation is available to the public in source code form. A -"Major Component", in this context, means a major essential component -(kernel, window system, and so on) of the specific operating system -(if any) on which the executable work runs, or a compiler used to -produce the work, or an object code interpreter used to run it. - - The "Corresponding Source" for a work in object code form means all -the source code needed to generate, install, and (for an executable -work) run the object code and to modify the work, including scripts to -control those activities. However, it does not include the work's -System Libraries, or general-purpose tools or generally available free -programs which are used unmodified in performing those activities but -which are not part of the work. For example, Corresponding Source -includes interface definition files associated with source files for -the work, and the source code for shared libraries and dynamically -linked subprograms that the work is specifically designed to require, -such as by intimate data communication or control flow between those -subprograms and other parts of the work. - - The Corresponding Source need not include anything that users -can regenerate automatically from other parts of the Corresponding -Source. - - The Corresponding Source for a work in source code form is that -same work. - - 2. Basic Permissions. - - All rights granted under this License are granted for the term of -copyright on the Program, and are irrevocable provided the stated -conditions are met. This License explicitly affirms your unlimited -permission to run the unmodified Program. The output from running a -covered work is covered by this License only if the output, given its -content, constitutes a covered work. This License acknowledges your -rights of fair use or other equivalent, as provided by copyright law. - - You may make, run and propagate covered works that you do not -convey, without conditions so long as your license otherwise remains -in force. You may convey covered works to others for the sole purpose -of having them make modifications exclusively for you, or provide you -with facilities for running those works, provided that you comply with -the terms of this License in conveying all material for which you do -not control copyright. Those thus making or running the covered works -for you must do so exclusively on your behalf, under your direction -and control, on terms that prohibit them from making any copies of -your copyrighted material outside their relationship with you. - - Conveying under any other circumstances is permitted solely under -the conditions stated below. Sublicensing is not allowed; section 10 -makes it unnecessary. - - 3. Protecting Users' Legal Rights From Anti-Circumvention Law. - - No covered work shall be deemed part of an effective technological -measure under any applicable law fulfilling obligations under article -11 of the WIPO copyright treaty adopted on 20 December 1996, or -similar laws prohibiting or restricting circumvention of such -measures. - - When you convey a covered work, you waive any legal power to forbid -circumvention of technological measures to the extent such circumvention -is effected by exercising rights under this License with respect to -the covered work, and you disclaim any intention to limit operation or -modification of the work as a means of enforcing, against the work's -users, your or third parties' legal rights to forbid circumvention of -technological measures. - - 4. Conveying Verbatim Copies. - - You may convey verbatim copies of the Program's source code as you -receive it, in any medium, provided that you conspicuously and -appropriately publish on each copy an appropriate copyright notice; -keep intact all notices stating that this License and any -non-permissive terms added in accord with section 7 apply to the code; -keep intact all notices of the absence of any warranty; and give all -recipients a copy of this License along with the Program. - - You may charge any price or no price for each copy that you convey, -and you may offer support or warranty protection for a fee. - - 5. Conveying Modified Source Versions. - - You may convey a work based on the Program, or the modifications to -produce it from the Program, in the form of source code under the -terms of section 4, provided that you also meet all of these conditions: - - a) The work must carry prominent notices stating that you modified - it, and giving a relevant date. - - b) The work must carry prominent notices stating that it is - released under this License and any conditions added under section - 7. This requirement modifies the requirement in section 4 to - "keep intact all notices". - - c) You must license the entire work, as a whole, under this - License to anyone who comes into possession of a copy. This - License will therefore apply, along with any applicable section 7 - additional terms, to the whole of the work, and all its parts, - regardless of how they are packaged. This License gives no - permission to license the work in any other way, but it does not - invalidate such permission if you have separately received it. - - d) If the work has interactive user interfaces, each must display - Appropriate Legal Notices; however, if the Program has interactive - interfaces that do not display Appropriate Legal Notices, your - work need not make them do so. - - A compilation of a covered work with other separate and independent -works, which are not by their nature extensions of the covered work, -and which are not combined with it such as to form a larger program, -in or on a volume of a storage or distribution medium, is called an -"aggregate" if the compilation and its resulting copyright are not -used to limit the access or legal rights of the compilation's users -beyond what the individual works permit. Inclusion of a covered work -in an aggregate does not cause this License to apply to the other -parts of the aggregate. - - 6. Conveying Non-Source Forms. - - You may convey a covered work in object code form under the terms -of sections 4 and 5, provided that you also convey the -machine-readable Corresponding Source under the terms of this License, -in one of these ways: - - a) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by the - Corresponding Source fixed on a durable physical medium - customarily used for software interchange. - - b) Convey the object code in, or embodied in, a physical product - (including a physical distribution medium), accompanied by a - written offer, valid for at least three years and valid for as - long as you offer spare parts or customer support for that product - model, to give anyone who possesses the object code either (1) a - copy of the Corresponding Source for all the software in the - product that is covered by this License, on a durable physical - medium customarily used for software interchange, for a price no - more than your reasonable cost of physically performing this - conveying of source, or (2) access to copy the - Corresponding Source from a network server at no charge. - - c) Convey individual copies of the object code with a copy of the - written offer to provide the Corresponding Source. This - alternative is allowed only occasionally and noncommercially, and - only if you received the object code with such an offer, in accord - with subsection 6b. - - d) Convey the object code by offering access from a designated - place (gratis or for a charge), and offer equivalent access to the - Corresponding Source in the same way through the same place at no - further charge. You need not require recipients to copy the - Corresponding Source along with the object code. If the place to - copy the object code is a network server, the Corresponding Source - may be on a different server (operated by you or a third party) - that supports equivalent copying facilities, provided you maintain - clear directions next to the object code saying where to find the - Corresponding Source. Regardless of what server hosts the - Corresponding Source, you remain obligated to ensure that it is - available for as long as needed to satisfy these requirements. - - e) Convey the object code using peer-to-peer transmission, provided - you inform other peers where the object code and Corresponding - Source of the work are being offered to the general public at no - charge under subsection 6d. - - A separable portion of the object code, whose source code is excluded -from the Corresponding Source as a System Library, need not be -included in conveying the object code work. - - A "User Product" is either (1) a "consumer product", which means any -tangible personal property which is normally used for personal, family, -or household purposes, or (2) anything designed or sold for incorporation -into a dwelling. In determining whether a product is a consumer product, -doubtful cases shall be resolved in favor of coverage. For a particular -product received by a particular user, "normally used" refers to a -typical or common use of that class of product, regardless of the status -of the particular user or of the way in which the particular user -actually uses, or expects or is expected to use, the product. A product -is a consumer product regardless of whether the product has substantial -commercial, industrial or non-consumer uses, unless such uses represent -the only significant mode of use of the product. - - "Installation Information" for a User Product means any methods, -procedures, authorization keys, or other information required to install -and execute modified versions of a covered work in that User Product from -a modified version of its Corresponding Source. The information must -suffice to ensure that the continued functioning of the modified object -code is in no case prevented or interfered with solely because -modification has been made. - - If you convey an object code work under this section in, or with, or -specifically for use in, a User Product, and the conveying occurs as -part of a transaction in which the right of possession and use of the -User Product is transferred to the recipient in perpetuity or for a -fixed term (regardless of how the transaction is characterized), the -Corresponding Source conveyed under this section must be accompanied -by the Installation Information. But this requirement does not apply -if neither you nor any third party retains the ability to install -modified object code on the User Product (for example, the work has -been installed in ROM). - - The requirement to provide Installation Information does not include a -requirement to continue to provide support service, warranty, or updates -for a work that has been modified or installed by the recipient, or for -the User Product in which it has been modified or installed. Access to a -network may be denied when the modification itself materially and -adversely affects the operation of the network or violates the rules and -protocols for communication across the network. - - Corresponding Source conveyed, and Installation Information provided, -in accord with this section must be in a format that is publicly -documented (and with an implementation available to the public in -source code form), and must require no special password or key for -unpacking, reading or copying. - - 7. Additional Terms. - - "Additional permissions" are terms that supplement the terms of this -License by making exceptions from one or more of its conditions. -Additional permissions that are applicable to the entire Program shall -be treated as though they were included in this License, to the extent -that they are valid under applicable law. If additional permissions -apply only to part of the Program, that part may be used separately -under those permissions, but the entire Program remains governed by -this License without regard to the additional permissions. - - When you convey a copy of a covered work, you may at your option -remove any additional permissions from that copy, or from any part of -it. (Additional permissions may be written to require their own -removal in certain cases when you modify the work.) You may place -additional permissions on material, added by you to a covered work, -for which you have or can give appropriate copyright permission. - - Notwithstanding any other provision of this License, for material you -add to a covered work, you may (if authorized by the copyright holders of -that material) supplement the terms of this License with terms: - - a) Disclaiming warranty or limiting liability differently from the - terms of sections 15 and 16 of this License; or - - b) Requiring preservation of specified reasonable legal notices or - author attributions in that material or in the Appropriate Legal - Notices displayed by works containing it; or - - c) Prohibiting misrepresentation of the origin of that material, or - requiring that modified versions of such material be marked in - reasonable ways as different from the original version; or - - d) Limiting the use for publicity purposes of names of licensors or - authors of the material; or - - e) Declining to grant rights under trademark law for use of some - trade names, trademarks, or service marks; or - - f) Requiring indemnification of licensors and authors of that - material by anyone who conveys the material (or modified versions of - it) with contractual assumptions of liability to the recipient, for - any liability that these contractual assumptions directly impose on - those licensors and authors. - - All other non-permissive additional terms are considered "further -restrictions" within the meaning of section 10. If the Program as you -received it, or any part of it, contains a notice stating that it is -governed by this License along with a term that is a further -restriction, you may remove that term. If a license document contains -a further restriction but permits relicensing or conveying under this -License, you may add to a covered work material governed by the terms -of that license document, provided that the further restriction does -not survive such relicensing or conveying. - - If you add terms to a covered work in accord with this section, you -must place, in the relevant source files, a statement of the -additional terms that apply to those files, or a notice indicating -where to find the applicable terms. - - Additional terms, permissive or non-permissive, may be stated in the -form of a separately written license, or stated as exceptions; -the above requirements apply either way. - - 8. Termination. - - You may not propagate or modify a covered work except as expressly -provided under this License. Any attempt otherwise to propagate or -modify it is void, and will automatically terminate your rights under -this License (including any patent licenses granted under the third -paragraph of section 11). - - However, if you cease all violation of this License, then your -license from a particular copyright holder is reinstated (a) -provisionally, unless and until the copyright holder explicitly and -finally terminates your license, and (b) permanently, if the copyright -holder fails to notify you of the violation by some reasonable means -prior to 60 days after the cessation. - - Moreover, your license from a particular copyright holder is -reinstated permanently if the copyright holder notifies you of the -violation by some reasonable means, this is the first time you have -received notice of violation of this License (for any work) from that -copyright holder, and you cure the violation prior to 30 days after -your receipt of the notice. - - Termination of your rights under this section does not terminate the -licenses of parties who have received copies or rights from you under -this License. If your rights have been terminated and not permanently -reinstated, you do not qualify to receive new licenses for the same -material under section 10. - - 9. Acceptance Not Required for Having Copies. - - You are not required to accept this License in order to receive or -run a copy of the Program. Ancillary propagation of a covered work -occurring solely as a consequence of using peer-to-peer transmission -to receive a copy likewise does not require acceptance. However, -nothing other than this License grants you permission to propagate or -modify any covered work. These actions infringe copyright if you do -not accept this License. Therefore, by modifying or propagating a -covered work, you indicate your acceptance of this License to do so. - - 10. Automatic Licensing of Downstream Recipients. - - Each time you convey a covered work, the recipient automatically -receives a license from the original licensors, to run, modify and -propagate that work, subject to this License. You are not responsible -for enforcing compliance by third parties with this License. - - An "entity transaction" is a transaction transferring control of an -organization, or substantially all assets of one, or subdividing an -organization, or merging organizations. If propagation of a covered -work results from an entity transaction, each party to that -transaction who receives a copy of the work also receives whatever -licenses to the work the party's predecessor in interest had or could -give under the previous paragraph, plus a right to possession of the -Corresponding Source of the work from the predecessor in interest, if -the predecessor has it or can get it with reasonable efforts. - - You may not impose any further restrictions on the exercise of the -rights granted or affirmed under this License. For example, you may -not impose a license fee, royalty, or other charge for exercise of -rights granted under this License, and you may not initiate litigation -(including a cross-claim or counterclaim in a lawsuit) alleging that -any patent claim is infringed by making, using, selling, offering for -sale, or importing the Program or any portion of it. - - 11. Patents. - - A "contributor" is a copyright holder who authorizes use under this -License of the Program or a work on which the Program is based. The -work thus licensed is called the contributor's "contributor version". - - A contributor's "essential patent claims" are all patent claims -owned or controlled by the contributor, whether already acquired or -hereafter acquired, that would be infringed by some manner, permitted -by this License, of making, using, or selling its contributor version, -but do not include claims that would be infringed only as a -consequence of further modification of the contributor version. For -purposes of this definition, "control" includes the right to grant -patent sublicenses in a manner consistent with the requirements of -this License. - - Each contributor grants you a non-exclusive, worldwide, royalty-free -patent license under the contributor's essential patent claims, to -make, use, sell, offer for sale, import and otherwise run, modify and -propagate the contents of its contributor version. - - In the following three paragraphs, a "patent license" is any express -agreement or commitment, however denominated, not to enforce a patent -(such as an express permission to practice a patent or covenant not to -sue for patent infringement). To "grant" such a patent license to a -party means to make such an agreement or commitment not to enforce a -patent against the party. - - If you convey a covered work, knowingly relying on a patent license, -and the Corresponding Source of the work is not available for anyone -to copy, free of charge and under the terms of this License, through a -publicly available network server or other readily accessible means, -then you must either (1) cause the Corresponding Source to be so -available, or (2) arrange to deprive yourself of the benefit of the -patent license for this particular work, or (3) arrange, in a manner -consistent with the requirements of this License, to extend the patent -license to downstream recipients. "Knowingly relying" means you have -actual knowledge that, but for the patent license, your conveying the -covered work in a country, or your recipient's use of the covered work -in a country, would infringe one or more identifiable patents in that -country that you have reason to believe are valid. - - If, pursuant to or in connection with a single transaction or -arrangement, you convey, or propagate by procuring conveyance of, a -covered work, and grant a patent license to some of the parties -receiving the covered work authorizing them to use, propagate, modify -or convey a specific copy of the covered work, then the patent license -you grant is automatically extended to all recipients of the covered -work and works based on it. - - A patent license is "discriminatory" if it does not include within -the scope of its coverage, prohibits the exercise of, or is -conditioned on the non-exercise of one or more of the rights that are -specifically granted under this License. You may not convey a covered -work if you are a party to an arrangement with a third party that is -in the business of distributing software, under which you make payment -to the third party based on the extent of your activity of conveying -the work, and under which the third party grants, to any of the -parties who would receive the covered work from you, a discriminatory -patent license (a) in connection with copies of the covered work -conveyed by you (or copies made from those copies), or (b) primarily -for and in connection with specific products or compilations that -contain the covered work, unless you entered into that arrangement, -or that patent license was granted, prior to 28 March 2007. - - Nothing in this License shall be construed as excluding or limiting -any implied license or other defenses to infringement that may -otherwise be available to you under applicable patent law. - - 12. No Surrender of Others' Freedom. - - If conditions are imposed on you (whether by court order, agreement or -otherwise) that contradict the conditions of this License, they do not -excuse you from the conditions of this License. If you cannot convey a -covered work so as to satisfy simultaneously your obligations under this -License and any other pertinent obligations, then as a consequence you may -not convey it at all. For example, if you agree to terms that obligate you -to collect a royalty for further conveying from those to whom you convey -the Program, the only way you could satisfy both those terms and this -License would be to refrain entirely from conveying the Program. - - 13. Use with the GNU Affero General Public License. - - Notwithstanding any other provision of this License, you have -permission to link or combine any covered work with a work licensed -under version 3 of the GNU Affero General Public License into a single -combined work, and to convey the resulting work. The terms of this -License will continue to apply to the part which is the covered work, -but the special requirements of the GNU Affero General Public License, -section 13, concerning interaction through a network will apply to the -combination as such. - - 14. Revised Versions of this License. - - The Free Software Foundation may publish revised and/or new versions of -the GNU General Public License from time to time. Such new versions will -be similar in spirit to the present version, but may differ in detail to -address new problems or concerns. - - Each version is given a distinguishing version number. If the -Program specifies that a certain numbered version of the GNU General -Public License "or any later version" applies to it, you have the -option of following the terms and conditions either of that numbered -version or of any later version published by the Free Software -Foundation. If the Program does not specify a version number of the -GNU General Public License, you may choose any version ever published -by the Free Software Foundation. - - If the Program specifies that a proxy can decide which future -versions of the GNU General Public License can be used, that proxy's -public statement of acceptance of a version permanently authorizes you -to choose that version for the Program. - - Later license versions may give you additional or different -permissions. However, no additional obligations are imposed on any -author or copyright holder as a result of your choosing to follow a -later version. - - 15. Disclaimer of Warranty. - - THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY -APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT -HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY -OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, -THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR -PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM -IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF -ALL NECESSARY SERVICING, REPAIR OR CORRECTION. - - 16. Limitation of Liability. - - IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING -WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS -THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY -GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE -USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF -DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD -PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), -EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF -SUCH DAMAGES. - - 17. Interpretation of Sections 15 and 16. - - If the disclaimer of warranty and limitation of liability provided -above cannot be given local legal effect according to their terms, -reviewing courts shall apply local law that most closely approximates -an absolute waiver of all civil liability in connection with the -Program, unless a warranty or assumption of liability accompanies a -copy of the Program in return for a fee. - - END OF TERMS AND CONDITIONS - - How to Apply These Terms to Your New Programs - - If you develop a new program, and you want it to be of the greatest -possible use to the public, the best way to achieve this is to make it -free software which everyone can redistribute and change under these terms. - - To do so, attach the following notices to the program. It is safest -to attach them to the start of each source file to most effectively -state the exclusion of warranty; and each file should have at least -the "copyright" line and a pointer to where the full notice is found. - - - Copyright (C) - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU General Public License for more details. - - You should have received a copy of the GNU General Public License - along with this program. If not, see . - -Also add information on how to contact you by electronic and paper mail. - - If the program does terminal interaction, make it output a short -notice like this when it starts in an interactive mode: - - Copyright (C) - This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'. - This is free software, and you are welcome to redistribute it - under certain conditions; type `show c' for details. - -The hypothetical commands `show w' and `show c' should show the appropriate -parts of the General Public License. Of course, your program's commands -might be different; for a GUI interface, you would use an "about box". - - You should also get your employer (if you work as a programmer) or school, -if any, to sign a "copyright disclaimer" for the program, if necessary. -For more information on this, and how to apply and follow the GNU GPL, see -. - - The GNU General Public License does not permit incorporating your program -into proprietary programs. If your program is a subroutine library, you -may consider it more useful to permit linking proprietary applications with -the library. If this is what you want to do, use the GNU Lesser General -Public License instead of this License. But first, please read -. diff --git a/lisp/erk.el b/lisp/erk.el index 25da8b8..b1662e4 100644 --- a/lisp/erk.el +++ b/lisp/erk.el @@ -28,11 +28,11 @@ ;;; Commentary: ;; Set up Emacs package with GitHub repository configuration, complete with -;; Actions CI, tests, lints, and a licensing scheme all ready to go. Included -;; commands are focused on productivity, appropriate for professional -;; development in elisp. The goal of the package is streamline authoring & -;; distributing new Emacs packages. It provides a well-integrated but rigid -;; scheme, aka opinionated. +;; Actions CI, tests, lints, documentation generation, and a licensing scheme +;; all ready to go. Included commands are focused on productivity, appropriate +;; for professional development in elisp. The goal of the package is streamline +;; authoring & distributing new Emacs packages. It provides a well-integrated +;; but rigid scheme, aka opinionated. ;; ;; The package also uses its own hosted source as a substrate for creating new ;; packages. It will clone its source repository and then perform renaming & @@ -62,29 +62,46 @@ (defgroup erk nil "Elisp repository kit." :prefix 'erk :group 'programming) -(defcustom erk-replace-author "Positron Solutions " - "Default author for renaming." - :group 'erk - :type 'string) +(defcustom erk-templates + '((erk-basic :github-path "positron-solutions/erk-basic")) + "Alist of template repositories configured for cloning in `erk-new'. +Each value form is a plist with keys: -(defcustom erk-replace-github-package-name "elisp-repo-kit" - "Default GitHub project for renaming. -If you rename this repository after forking, you need to set this -to clone from within the fork." - :group 'erk - :type 'string) +- `:github-path`: Github style path, `user-or-org/repo'. -(defcustom erk-replace-package-prefix "erk" - "The prefix is used to features and file names." - :group 'erk - :type 'string) +- `:feature`: By convention, the root feature decides file names. + If nil, uses repo in the github-path. -(defcustom erk-replace-github-userorg "positron-solutions" - "Default GitHub user-or-org for renaming. -If you fork this repository, you need to set this to clone it -from within the fork." +- `:prefix`: Elisp namespace prefix, usually the same as feature + but sometimes it is a contraction or initialism. If nil, uses + feature or repo in the github-path. + +- `:title`: Optional. The package usually has a longer name + present in it's root feature's header. Set title to specify + this or rely on `erk-package-title' to infer it. + +Template information is likely to grow in the future to support +templates with different layouts and other requirements." :group 'erk - :type 'string) + :type '(alist :key-type symbol :value-type plist)) + +(defun erk--template-github-userorg (template) + "Get the github repo from a TEMPLATE." + (car (split-string (plist-get template :github-path) "/"))) + +(defun erk--template-github-repo (template) + "Get the github repo from a TEMPLATE." + (cadr (split-string (plist-get template :github-path) "/"))) + +(defun erk--template-feature (template) + "Get the feature from TEMPLATE. +Falls back to github repo from :github-path." + (or (plist-get template :feature) (erk--template-github-repo template))) + +(defun erk--template-prefix (template) + "Get the prefix from TEMPLATE. +Falls back to :prefix and then the repo from :github-path." + (or (plist-get template :prefix) (erk--template-feature template))) (defconst erk--gpl3-notice ";; This program is free software; \ you can redistribute it and/or modify @@ -100,18 +117,35 @@ you can redistribute it and/or modify ;; You should have received a copy of the GNU General Public License ;; along with this program. If not, see .") +;; TODO In order to work with a variety of repos with valid Elisp package +;; layouts, these variables should replaced with file discovery. Then the +;; templates should contain any custom renaming information specific to their +;; layout and content. Finally, re-licensing should be made dynamic and able to +;; use a combination of discovery and template information to. PR's for any of +;; these tweaks will be gladly accepted. (defconst erk--rename-maps '(( nil "gpl-3.0.txt" "COPYING") - ("lisp/" "erk.el" nil) - ("test/" "erk-test.el" nil)) - "List of (directory file replacement-file) forms.") + ("lisp/" "%s.el" nil) + ("test/" "%s-test.el" nil)) + "List of (DIR SRC DEST) forms.") (defconst erk--files-with-strings - '(;; "docs/manual.org" - ;; "docs/README.org" - "lisp/erk.el" - "test/erk-test.el" - ".github/run-shim.el")) + '("docs/manual.org" + "docs/README.org" + "lisp/%s.el" + "test/%s-test.el" + ".github/run-shim.el") + "Files for general string replacement.") + +(defconst erk--files-with-copy-notices + '("lisp/%s.el") + "Files that need copy notice replacement.") + +(defun erk--expand-filenames (files feature) + "Render the FEATURE into the list of FILES." + (mapcar + (lambda (f) (format f feature)) + files)) (defconst erk--delete-files '(".github/FUNDING.yml") @@ -149,15 +183,19 @@ you can redistribute it and/or modify (byte-compile-file (concat dir "/" (symbol-name feature) ".el")))) (require feature)))) +(defun erk--dir-elisp-files (dir) + "Return a list of the elisp files in DIR. +Ignore autoloads." + (->> + (directory-files dir nil (rx ".el" string-end)) + (--reject (string-match-p (rx "autoloads.el" string-end) it)))) + (defun erk--dir-features (dir) "Return list of features provided by elisp files in DIR. -Except autoloads." - (let* ((package-files (directory-files dir nil (rx ".el" string-end))) - (package-files (->> package-files - (--reject (string-match-p (rx "autoloads.el" string-end) it))))) - (mapcar - (lambda (f) (intern (string-remove-suffix ".el" f))) - package-files))) +Ignore autoloads." + (mapcar + (lambda (f) (intern (string-remove-suffix ".el" f))) + (erk--dir-elisp-files dir))) (defun erk--package-features () "List the features defined by the project's package. @@ -186,6 +224,7 @@ Only understands project root or root/lisp." (if (file-exists-p lisp-subdir) lisp-subdir project-root))) +;; TODO quite redundant (defun erk--project-root-feature-file () "Return the path of the root feature for the project." (let* ((project-elisp-dir (erk--project-elisp-dir)) @@ -207,6 +246,15 @@ Only understands project root or root/lisp." "Return the version of this project's package." (lm-version (erk--project-root-feature-file))) +(defun erk-package-title () + "Return the title of the package for documentation." + (let ((file(erk--project-root-feature-file))) + (with-temp-buffer + (insert-file-contents file) + (goto-char (point-min)) + (when (re-search-forward "---\\(.*?\\)-\\*-" nil t) + (string-trim (match-string 1)))))) + ;;;###autoload (defun erk-reload-project-package () "Reload the features this project provides. @@ -304,34 +352,44 @@ ERROR is the error message." (pop-to-buffer "erk-clone") (error ,error))) -(defun erk--rename-package (dir old-package new-package) - "Rename FILES in DIR. -`erk--rename-map' is a list of (subdir filename -replacement-filename) triples. When subdir is nil, it means use -DIR. If replacement-filename is nil means replace OLD-PACKAGE -with NEW-PACKAGE, using `replace-regexp-in-string'. DIR is the -root of where we are renaming. Existing files will be -clobbered." - (mapc (lambda (f) (delete-file (concat (file-name-as-directory dir) f))) +(defun erk--rename-package (template clone-dir replacements) + "Rename files in CLONE-DIR. +TEMPLATE is a form described in `erk-templates'. REPLACEMENTS is +a form from `erk-new'. + +`erk--rename-map' is a list of (SUBDIR SRC DEST) triples. When +SUBDIR is nil, the path is CLONE-DIR itself. If DEST is nil +means replace old-feature with new-feature, using +`replace-regexp-in-string'. CLONE-DIR is the root of where we +are renaming. Existing files will be clobbered." + (mapc (lambda (f) (delete-file (concat (file-name-as-directory clone-dir) f))) erk--delete-files) - (mapc (lambda (rename-map) - (let* ((dir (concat dir (or (pop rename-map) ""))) - (src (pop rename-map)) - (replacement-filename (pop rename-map)) - (git-bin (executable-find "git")) - (output (get-buffer-create "erk-clone")) - (dest (or replacement-filename - (replace-regexp-in-string old-package new-package src))) - (default-directory dir)) - (when (file-exists-p dest) + ;; Note, dashes removed from inputs in `erk-new', but left here just in case + ;; called from Elisp. + (let* ((old-feature (erk--nodash (erk--template-feature template))) + (new-feature (erk--nodash (plist-get replacements :feature))) + (output (get-buffer-create "erk-clone")) + (git-bin (executable-find "git"))) + (mapc (lambda (rename-map) + (let* ((dir (concat clone-dir (or (pop rename-map) ""))) + (src (format (pop rename-map) old-feature)) + (new-filename (when-let ((file (pop rename-map))) + (format + file + new-feature))) + (dest (or new-filename + (replace-regexp-in-string + (rx (literal old-feature)) new-feature src))) + (default-directory dir)) + (when (file-exists-p dest) + (erk--nze + (call-process git-bin nil output nil "rm" "-f" dest) + (format "Could not delete: %s" dest))) (erk--nze - (call-process git-bin nil output nil "rm" "-f" dest) - (format "Could not delete: %s" dest))) - (erk--nze - (call-process git-bin nil output nil "mv" src dest) - (format "Could not move: %s to %s" src dest)))) - erk--rename-maps)) + (call-process git-bin nil output nil "mv" src dest) + (format "Could not move: %s to %s" src dest)))) + erk--rename-maps))) (defun erk--nodash (prefix) "Strip dash from PREFIX if present." @@ -345,89 +403,102 @@ clobbered." (group (literal (erk--nodash prefix))) (or whitespace punctuation eol))) -(defun erk--replace-strings (dir package-name package-prefix author user-org email) +(defun erk--replace-strings (template clone-path replacements) "Replace values in files that need renaming or re-licensing. -DIR is where we are replacing. PACKAGE-NAME is the new -package. PACKAGE-PREFIX is the elisp prefix. AUTHOR will be -used in copyright notices. USER-ORG will be used as the first -part of the new github path. EMAIL is shown after AUTHOR in -package headers." - (let ((default-directory dir) - (erk-github-path (concat erk-replace-github-userorg "/" - erk-replace-github-package-name)) - (github-path (concat user-org "/" package-name)) - (package-prefix package-prefix) - (replace-prefix (erk--prefix-match erk-replace-package-prefix)) - (capitalized-package-title - (string-join (mapcar #'capitalize - (split-string package-name "-")) - " ")) - (replace-package-title - (string-join (mapcar #'capitalize - (split-string erk-replace-github-package-name "-")) - " "))) +TEMPLATE forms are from `erk-templates'. CLONE-PATH is where we +are renaming. The REPLACEMENTS form is described in `erk-new'." + (let* ((default-directory clone-path) + (old-title (or (plist-get template :title) + (erk-package-title))) + (new-title (plist-get replacements :title)) + (old-github-path (plist-get template :github-path)) + (new-github-path (concat (plist-get replacements :user-org) + "/" + (plist-get replacements :feature))) + (old-author (erk-package-author)) + (new-author (plist-get replacements :author)) + (old-email (erk-package-email)) + (new-email (plist-get replacements :email)) + ;; Note, dashes are stripped off of inputs in the read, but left here + ;; in case this is called from Elisp. + (old-feature (erk--template-feature template)) + (old-feature-rx (erk--prefix-match old-feature)) + (new-feature (erk--nodash (plist-get replacements :feature))) + (old-prefix-rx (erk--prefix-match (erk--template-prefix template))) + (new-prefix (erk--nodash (plist-get replacements :prefix))) + ;; Render old-feature into files. + (files (erk--expand-filenames erk--files-with-strings old-feature)) + (copy-notice-files (erk--expand-filenames erk--files-with-copy-notices old-feature))) (mapc (lambda (file) - (with-current-buffer (find-file-noselect (concat dir file) t t) - ;; append new author to copyright + (with-current-buffer (find-file-noselect (concat clone-path file) t t) (print (format "visiting: %s" (buffer-file-name))) (mapc (lambda (s) (while (re-search-forward (rx (literal s)) nil t) (replace-match "") (goto-char (point-min)))) erk--remove-strings) - (when (re-search-forward (rx bol ";; Copyright") nil t) - (end-of-line) - (insert ", " author)) + ;; Try to replace strings in an order that limits the likelihood of + ;; substring collisions. + + ;; replace title, case-insensitively + (goto-char (point-min)) + (while (re-search-forward (rx (literal old-title)) nil t) + (replace-match new-title nil t)) + ;; replace github paths (goto-char (point-min)) - (when (re-search-forward (rx (literal erk-replace-author) eol) nil t) - (replace-match (concat author " <" email ">") nil t)) + (while (re-search-forward (rx (literal old-github-path)) nil t) + (replace-match new-github-path nil t)) + ;; replace author (goto-char (point-min)) - ;; replace license with GPL3 notice - (when (re-search-forward ";; Permission \\(.\\|\n\\)*SOFTWARE.$" nil t) - (replace-match erk--gpl3-notice nil t)) + (while (re-search-forward (rx (literal old-author)) nil t) + (replace-match new-author nil t)) + ;; replace email (goto-char (point-min)) - ;; update github paths for README links - (while (re-search-forward erk-github-path nil t) - (replace-match github-path nil t)) + (while (re-search-forward (rx (literal old-email)) nil t) + (replace-match new-email nil t)) + ;; replace feature (goto-char (point-min)) - ;; replace package prefix. Uses group replacement. - (while (re-search-forward replace-prefix nil t) - (replace-match package-prefix nil t nil 1)) + (while (re-search-forward old-feature-rx nil t) + (replace-match new-feature nil t nil 1)) ; replace sub-expression + ;; replace prefix (goto-char (point-min)) - ;; update remaining package name strings. - (while (re-search-forward erk-replace-github-package-name nil t) - (replace-match package-name nil t)) + (while (re-search-forward old-prefix-rx nil t) + (replace-match new-prefix nil t nil 1)) ; replace sub-expression + (when (member file copy-notice-files) + ;; replace license with GPL3 notice + (when (re-search-forward ";; Permission \\(.\\|\n\\)*SOFTWARE.$" nil t) + (replace-match erk--gpl3-notice nil t))) (goto-char (point-min)) - (while (re-search-forward replace-package-title nil t) - (replace-match capitalized-package-title nil t)) (save-buffer 0) (kill-buffer))) - erk--files-with-strings))) + files))) + +(defun erk-clone (template clone-root replacements) + "Clone the template repository to CLONE-ROOT and apply rename. +TEMPLATE is the same as forms in `erk-templates'. +REPLACEMENTS is the form described in `erk-new'. + +The folder will be renamed to the `:feature' value in +REPLACEMENTS. The remote will be configured to point to the +`:user-org' value in REPLACEMENTS." -;;;###autoload -(defun erk-clone (clone-root package-name user-org &optional rev) - "Clone elisp-repo-kit to CLONE-ROOT and apply rename. -PACKAGE-NAME will instruct git how to name the clone. USER-ORG -is the user or organization you will use for your GitHub -repository. REV can be used to check out a specific revision. -Warning! The revision may have lost compatibility with the -rename script. Each rev is intended only to be able to rename -itself, as a quine and for forking as a new template repository." - (interactive "DClone to directory:") (if-let ((git-bin (executable-find "git"))) (let ((default-directory clone-root) - (output (get-buffer-create "erk-clone"))) + (output (get-buffer-create "erk-clone")) + (old-github-path (plist-get template :github-path)) + (new-feature (plist-get replacements :feature)) + (user-org (plist-get replacements :user-org))) (erk--nze (call-process git-bin nil output nil "clone" - (format "https://github.com/%s/%s.git" - erk-replace-github-userorg erk-replace-github-package-name) - (concat default-directory "/" package-name)) + (format "https://github.com/%s.git" old-github-path) + (concat default-directory "/" new-feature)) "Clone failed") - (let ((default-directory (concat clone-root "/" package-name)) - (rev (when rev (if (string-empty-p rev) nil rev)))) + (let* ((default-directory (concat clone-root "/" new-feature)) + (rev (plist-get template :rev)) + (rev (when rev (if (string-empty-p rev) nil rev)))) (when rev (erk--nze (call-process git-bin nil output nil "checkout" rev) (format "Checkout %s failed." rev))) @@ -441,88 +512,127 @@ itself, as a quine and for forking as a new template repository." (erk--nze (call-process git-bin nil output nil "remote" "add" "origin" (format "git@github.com:%s/%s.git" - user-org package-name)) + user-org new-feature)) "Adding new remote failed.") ;; return value for renaming - (concat clone-root "/" package-name "/"))) - (error "Could not find git executible"))) + (concat clone-root "/" new-feature "/"))) + (error "Could not find git executable"))) -;;;###autoload -(defun erk-rename-relicense (clone-dir package-name package-prefix author user-org email) - "Rename and relicense your clone of ERK. -CLONE-DIR is your elisp-repo-clone root. PACKAGE-NAME should be -the long name of the package, what will show up in melpa -etc. PACKAGE-PREFIX is the elisp symbol prefix. AUTHOR will be used -in copyright notices. USER-ORG is either your user or -organization, which forms the first part of a github repo path. -EMAIL is shown after AUTHOR in package headers. - -This command replaces all instances of: - -1. package name -2. author name (appended to copyright) -3. MIT license with GPL3 license notices in package files (not test files or CI) -4. github organization -5. COPYING is changed to just the GPL3. - -Then renames the files to reflect package name - -Finally, MIT licenses are swapped with GPL3 license notices. -Re-licensing is fully permitted by the MIT license and intended -by the author of this repository." - (interactive "DCloned directory: \nsPackage name: \nsAuthor: \ -\nsGitHub organization or username: \nsEmail: ") +(defun erk-rename-relicense (template clone-dir replacements) + "Rename and re-license your new cloned template. +CLONE-DIR is the root for renaming and string +replacement. TEMPLATE is the same forms described in +`erk-templates'. REPLACEMENTS is the form described in +`erk-new'. + +This function replaces all instances of: + +1. package title + +2. package feature + +3. package prefix + +4. author name (appended to copyright) + +5. author email + +6. github user-org + +7. MIT license with GPL3 license notices in package files (not +test, manual, or CI though) + +8. COPYING is changed to just the GPL3. + +9. Documentation is re-generated, containing the new strings." (erk--replace-strings - clone-dir package-name package-prefix author user-org email) - (erk--rename-package clone-dir erk-replace-package-prefix package-name) + template clone-dir replacements) + (erk--rename-package template clone-dir replacements) (let ((default-directory clone-dir)) (erk-export-docs))) ;;;###autoload -(defun erk-new (package-name package-prefix clone-root author user-org email &optional rev) - "Clone elisp-repo-kit, rename, and re-license in one step. -CLONE-ROOT is where you want to clone your package to (including -the clone dir). PACKAGE-NAME should be the long name of the -package, what will show up in melpa etc. PACKAGE-PREFIX can be -either the same as the package or a contracted form, such as an -initialism. AUTHOR will be used in copyright notices. USER-ORG -is either your user or organization, which forms the first part -of a github repo path. EMAIL is shown after AUTHOR in package -headers. Optional REV is either a tag, branch or revision used -in git checkout. +(defun erk-new (template clone-root replacements) + "Clone an ERK style template and rename files in one step. +TEMPLATE is the same forms described in `erk-templates'. + +CLONE-ROOT is where the path for the new clone will be created. + +REPLACEMENTS is a plist with keys: + +- `:full-name': The title of the package, usually found in the + README, manual, and the first line of Elisp files. + +- `:feature': By convention, all Elisp file names will include + the root feature. This will also be assumed to form the repo + segment of the new Github remote path. It's also what shows up + in MELPA and `use-package' declarations etc. + +- `:prefix': The Elisp namespace prefix, usually the same as the + root feature, but could be an initialism or contraction. + +- `:author': The new author's name. + +- `:email': Author email. + +- `:user-org': The Github username or organization, the first + part of a Github style path. + +- `:rev': Optional. Either a tag, branch or revision used in git + checkout. See comments in `erk-clone' and `erk-rename-relicense' for implementation information and more details about argument usage." (interactive (let* - ((package-name - (read-string - (format "Package name, such as %s: " erk-replace-github-package-name) - "foo")) - (package-prefix - (erk--nodash - (read-string - (format "Package prefix, such as %s: " erk-replace-package-prefix)))) + ((template (cdr (assoc-string (completing-read + "Select a template: " + erk-templates) + erk-templates))) + (rev (read-string + "Rev, tag, or branch (empty implies default branch): ")) + (template (plist-put template :rev rev)) (clone-root (directory-file-name (read-directory-name "Clone root: " default-directory))) + (title + (read-string + "Package full name, for documentation: " + "My Package")) + (feature + (erk--nodash + (read-string + "Package feature, used in use-package and MELPA etc: " + "my-feature"))) + (prefix + (erk--nodash + (read-string + "Package prefix, such as mp, my-package, mypak etc: " + "my-package"))) + (user-org (read-string "Github user or organization name: ")) (author (let ((default (when (executable-find "git") (string-trim (shell-command-to-string "git config user.name"))))) (read-string "Author: " default))) - (user-org (read-string "User or organization name: ")) + (email (let ((default (when (executable-find "git") (string-trim (shell-command-to-string "git config user.email"))))) - (read-string "Email: " default))) - (rev (read-string - "Rev, tag, or branch (empty implies default branch): "))) - (list package-name package-prefix clone-root author user-org email rev))) - (erk-rename-relicense - (erk-clone clone-root package-name user-org rev) - package-name package-prefix author user-org email)) + (read-string "Email: " default)))) + (list + template + clone-root + (list + :title title + :feature feature + :prefix prefix + :user-org user-org + :author author + :email email)))) + (let ((cloned (erk-clone template clone-root replacements))) + (erk-rename-relicense template cloned replacements))) ;;;###autoload (defun erk-insert-package-keyword (keyword) @@ -538,7 +648,7 @@ This list's name is easy to forget, so here's a shortcut." (format "%s\t%s" (car item) (cdr item)))))) (insert (format "\"%s\"" keyword))) -(defvar erk--find-paths +(defconst erk--find-paths '((ci-dco . ".github/workflows/dco.yml") (ci-nix-flake . ".github/flake.nix") (ci-run-shim . ".github/run-shim.el") diff --git a/test/erk-test.el b/test/erk-test.el index 542e7d7..3ea725d 100644 --- a/test/erk-test.el +++ b/test/erk-test.el @@ -52,21 +52,72 @@ (ert-deftest erk--test-features-test () (should (member 'erk-test (erk--test-features)))) -(ert-deftest erk-clone-and-rename-test () - "Clone the repo and rename it, single step." +(ert-deftest erk--template-github-userorg-test () + (should (string= (erk--template-github-userorg '(:github-path "positron-solutions/bitcoin-miner")) + "positron-solutions"))) + +(ert-deftest erk--template-github-repo-test () + (should (string= (erk--template-github-repo '(:github-path "positron-solutions/bitcoin-miner")) + "bitcoin-miner"))) + +(ert-deftest erk--template-feature-test () + (should (string= (erk--template-feature '(:github-path "positron-solutions/bitcoin-miner")) + "bitcoin-miner")) + (should (string= (erk--template-feature '(:github-path "positron-solutions/bitcoin-miner" + :feature "floozly")) + "floozly"))) + +(ert-deftest erk--template-prefix-test () + (should (string= (erk--template-prefix '(:github-path "positron-solutions/bitcoin-miner")) + "bitcoin-miner")) + (should (string= (erk--template-prefix '(:github-path "positron-solutions/bitcoin-miner" + :feature "floozly")) + "floozly")) + (should (string= (erk--template-prefix '(:github-path "positron-solutions/bitcoin-miner" + :feature "floozly" + :prefix "flombow")) + "flombow"))) + +(ert-deftest erk--expand-filenames-test () + (should (string= (car (erk--expand-filenames '("%s-foo.el") "doo")) + "doo-foo.el"))) + +(ert-deftest erk--project-elisp-dir-test () + (should (erk--project-elisp-dir))) + +(ert-deftest erk--project-package-email-test () + (should (string= (erk-package-email) "contact@positron.solutions"))) + +(ert-deftest erk--project-package-author-test () + (should (string= (erk-package-author) "Positron Solutions"))) + +(ert-deftest erk--nodash-test () + (should (string= (erk--nodash "erk-") "erk"))) + +(ert-deftest erk-clone-test () (let ((enable-local-variables nil) - (rev (string-trim - (shell-command-to-string "git rev-parse HEAD"))) (clone-root (make-temp-file "erk-clone-test-" t))) - ;; TODO This test is fragile and should use repository as the clone source. - (erk-new - "new-project" ; package-name - "nupro" ; package-prefix - clone-root - "Selindis Raszagal" ; Author - "new-shakuras" ; user-org - "selindis.r@new-shakuras.planet" ; email - rev) ; possibly nil + (erk-clone (cdr (assoc 'erk-basic erk-templates)) + clone-root + '(:title "Omg Test" + :prefix "ggg" + :email "mail@template.com" + :author "Huh Idk" + :feature "lol-pkg" + :user-org "zerglingscancode2")) + (delete-directory clone-root t))) + +(ert-deftest erk-new-test () + (let ((enable-local-variables nil) + (clone-root (make-temp-file "erk-clone-test-" t))) + (erk-new (cdr (assoc 'erk-basic erk-templates)) + clone-root + '(:title "Hilariously Good Package" + :feature "laughing-package" + :prefix "lol-pkg" + :user-org "zerglingscancode2" + :email "iamzerg@zergs.pwn" + :author "Zagara")) (delete-directory clone-root t))) (provide 'erk-test)