Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider R Package Scan button #2405

Open
kgartland-rstudio opened this issue Oct 18, 2024 · 0 comments
Open

Reconsider R Package Scan button #2405

kgartland-rstudio opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request renv

Comments

@kgartland-rstudio
Copy link
Collaborator

We ended up removing the R Package Scan button due to this bug:

#2403

Further discussion here:
https://positpbc.slack.com/archives/C05D7NZD52S/p1729259573066909

It would be nice to have a button that configures renv for users but the original implementation seemed to only add functionality if the user already had an renv/activate.R with either no renv.lock or a renv.lock file with missing or mismatched packages to the renv/library. Most real R users won't get into this scenario so the Scan button didn't offer much value.

Aron provided some prior art around renv management in the rsconnect package:
https://github.com/rstudio/rsconnect/blob/2fe8fdef45f843cfb1316fecb443ac30a0ed8a42/R/bundlePackageRenv.R#L1-L33

@kgartland-rstudio kgartland-rstudio added the enhancement New feature or request label Oct 18, 2024
@jonkeane jonkeane added the renv label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request renv
Projects
None yet
Development

No branches or pull requests

2 participants