Fix "view as scrollable element" not working #5680
Merged
+18
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was due to cell output metadata being set to
undefined
by the Positron notebook controllers, causing thescrollable
metadata to not be set here:positron/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts
Lines 766 to 769 in 54d791d
We now set metadata and also set
outputType
since it also makes life easier for the ipynb serializer:positron/extensions/ipynb/src/serializers.ts
Line 182 in 3a8978a
QA Notes