Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New connections modal #5606

Merged
merged 17 commits into from
Dec 12, 2024
Merged

New connections modal #5606

merged 17 commits into from
Dec 12, 2024

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Dec 4, 2024

Addresses #5687

First steps towards modals for creating new connections.

TODO

  • Extend the Driver interface with supported input types
  • UI for displaying the connection input values/managing the connections code
  • Improve the radio buttons behavior when options is not specified
  • Implement a first pass on generateCode that takes Inputs and returns code.
  • Implement the Connect button behavior
  • Back should preserve the selected interpreter.

Follow up issues

QA Notes

@dfalbel dfalbel requested a review from softwarenerd December 11, 2024 18:15
@dfalbel dfalbel marked this pull request as ready for review December 11, 2024 18:15
softwarenerd
softwarenerd previously approved these changes Dec 11, 2024
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to look into. There is inconsistent use of:

(() => localize('positron.newConnectionModalDialog.title', "Create New Connection"))() 

vs:

localize('positron.newConnectionModalDialog.title', "Create New Connection")

We've had some problems with embedding localize calls in JSX in production builds.

@dfalbel
Copy link
Contributor Author

dfalbel commented Dec 12, 2024

Thank you, I have updated the localize calls in 69b83d4

@dfalbel dfalbel merged commit fb306f8 into main Dec 12, 2024
5 checks passed
@dfalbel dfalbel deleted the feature/new-connection-modal branch December 12, 2024 13:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants