GitHub Action to automatically fix TypeScript formatting issues #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Track markdown rendering delays in parameter hints * Address code review comments
Bumps [dsaltares/fetch-gh-release-asset](https://github.com/dsaltares/fetch-gh-release-asset) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/dsaltares/fetch-gh-release-asset/releases) - [Commits](dsaltares/fetch-gh-release-asset@1.1.1...1.1.2) --- updated-dependencies: - dependency-name: dsaltares/fetch-gh-release-asset dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Move more terminal contrib code into terminalContrib
For #211672
* Don't process escapes in console Escape should only be used to close completions or other contextual help boxes * Preserve interrupted input in the console * Style interrupted input with disabled top-action-bar style
Part of #211647
* Let ark have maximum control over smart select Since we have a holistic tree-sitter approach that works well * Use default for `selectSubwords`
* move env config update into reusable function * ensure the initial project config is saved * update comments and function docs * Update pythonEnvironmentStepUtils.ts to support undefined envType * store the new project configuration in the StorageService * add initial `PositronNewProjectContribution` Using this new contribution, we can wait for workbench initialization and run the project initialization tasks. * use configuration flag to enable/disable Project Wizard configuration id: `positron.useProjectWizard` * enable new project when config enabled or dev context Add the flag to the Welcome page check as well. * comment on empty dependency array for `useEffect` * fix issue with clearing envType onEnvSetupSelected Although envType is irrelevant for the Existing Environment env setup type, clearing it from the config means that if the user chooses New Environment after having chosen Existing Environment, the envType will be cleared and the user will have to re-select it. The envType can be cleared if applicable when the project config is being constructed. * wrap `useState` initial values in arrow functions to avoid re-evaluation Some of the `useState`s in pythonEnvironmentStep involve function calls that re-computed on every render. To avoid the unnecessary re-computation, wrap the initial values in arrow functions.
This adds a new (off by default) eslint rule that disables two specific types of dangerous type assertions:
```ts
<Type>{...};
{...} as Type;
```
These are bad because they can easily hide missing properties and strictness errors
Right now just adding this rule but will assign out fixes to owners in different areas of the code
add event firing back + change nb ss outlineTarget
* Initial work on disconnect state for the connections pane * Add the code attribute and add docs for class attributes * no need for a `equals()` method as connections are not copiable, they don't get compared by value. * Use host and type to find unique connections * typo in connections * Apply suggestions from code review Co-authored-by: Isabel Zimmerman <[email protected]> Signed-off-by: Daniel Falbel <[email protected]> * Fix references to CopyError * Use separate inspectors for each supported connection * SqlAlchemy url as string * Update extensions/positron-connections/src/connection.ts Co-authored-by: Jonathan <[email protected]> Signed-off-by: Daniel Falbel <[email protected]> * Correctly match connections by their metadata --------- Signed-off-by: Daniel Falbel <[email protected]> Co-authored-by: Isabel Zimmerman <[email protected]> Co-authored-by: Jonathan <[email protected]>
Signed-off-by: Chapman Pendery <[email protected]>
I noticed in doing a fix in copilot that our 'count' function was glacially slow. This is significantly faster.
Address #3205. Ipykernel kernel and shell classes are singletons so the .instance calls in our fixtures don't do much. The slow part was the shell.reset. Removing autouse=True for both took the tests down from ~1min to ~30 seconds on my laptop. We also don't need a full shell.reset, we can just remove the variables added by a test. This took it down to ~20 seconds. Then there was a particularly slow test test_update_max_items_plus_one. I decided to monkey patch the MAX_ITEMS variable down to a smaller value for tests, since we're still testing the same logic. This took it down to ~14 seconds.
Replaced with SVG
…er (#3197) * move runtime selection lower down the stack * make python runtime manager a service * initial python runtime manager unit tests * only select runtime if updating python path does not fail
…le updates (#3223) Addresses #3044 where a view refresh was causing the data explorer internals to get into a partial/broken state. The bug in #3044 has been addressed. Also adds a kernel dependency for the shell fixture which does not work correctly without this when running a single unit tests with pytest -k
Add plot actions for save, copy, next, previous, and clear Hides refresh plot in release builds
* Only restore panel when opening the panel * Don't call `restorePanel()` from actions It's called if needed from `openView()` * Restore minimised and focused panel when opening a view
…uarto (#3107) * Update 'workbench.action.positronConsole.executeCode' to be used in Quarto * Remove monkeying around with `languageId` * Implement `_executeStatementRangeProvider` command, for extensions to use * Import new command * Fix what command returns (statement range, not range) * Apply suggestions from code review Co-authored-by: Davis Vaughan <[email protected]> Signed-off-by: Julia Silge <[email protected]> * Update return for command --------- Signed-off-by: Julia Silge <[email protected]> Co-authored-by: Davis Vaughan <[email protected]>
* auto trust new projects * implement new project startup barrier * only trust new folders * clean up comments * Update src/vs/workbench/services/positronNewProject/common/positronNewProjectService.ts Co-authored-by: sharon <[email protected]> Signed-off-by: Jonathan <[email protected]> --------- Signed-off-by: Jonathan <[email protected]> Co-authored-by: sharon <[email protected]>
* Use strict validation for types in generated comms * fix: `pixel_ratio` must be a float * raise json rpc error responses * Accept StrictFloat or StrictInt for number OpenRPC types * Fix pyright error --------- Co-authored-by: seem <[email protected]>
* nightly python ci * use latest pytest * only use ubuntu on upstream tests per-pr * move nightly tests * add default working-directory * try to move to latest macos * no macos latest yet * Update .github/workflows/positron-python-ci.yml Co-authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Isabel Zimmerman <[email protected]> * remove runs from PR, add 3.8 and 3.12 --------- Signed-off-by: Isabel Zimmerman <[email protected]>
…s. (#3235) * Fix bug introduced when we added keybindings to the positron notebooks. * Completely remove the notebook context key dead-code.
Remove plots list update now that the close event is correctly triggered to run clean up
wesm
force-pushed
the
github-action-prettier
branch
from
0504cf0 to
067348f
Compare
wesm
force-pushed
the
github-action-prettier
branch
from
360d03b to
03ed885
Compare
|
Seems like prettier may be fussy about about the version of Node in use (since prettier is making some minor changes), and it may make sense to run this inside the Python CI lint job so it's all in one place |
isabelizimm
reviewed
May 23, 2024
| on: pull_request | ||
|
|
||
| env: | ||
| PYTHON_DIR: 'extensions/positron-python' |
There was a problem hiding this comment.
Suggested change
| PYTHON_DIR: 'extensions/positron-python' | |
| PYTHON_DIR: 'extensions/positron-python' | |
| NODE_VERSION: '18.17.1' |
we do this in other ci, it will likely help with the fussiness of versions
There was a problem hiding this comment.
Another option is to put this in the Python CI lint job like you suggested if we don't want to maintain in 2 locations, and add needs: format to the lint CI job so the lint CI won't try to run before we have formatted the files
|
@isabelizimm @seeM would one of you be interested in picking this up and incorporating it into the main Python extension CI job? No urgency I guess but it would save time and result in fewer broken CI builds |
|
I'm happy to clean it up! I'll look at it in the near future 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.