Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Positron's modals #5676

Open
jennybc opened this issue Dec 9, 2024 · 3 comments
Open

Revisit Positron's modals #5676

jennybc opened this issue Dec 9, 2024 · 3 comments
Assignees
Labels
area: ui Issues related to UI category.

Comments

@jennybc
Copy link
Member

jennybc commented Dec 9, 2024

Capturing a recent Slack conversation inspired by #5648. In that PR, at first I used vscode.window.showWarningMessage(), which looked like this, for modal: true vs. false:

Image
Image

This approach was ultimately rejected in favor of using Positron's API for this, in order to accomodate Workbench. Here's the current result with positron.window.showSimpleModalDialogPrompt():

Image

There's definitely room for improvement here and @softwarenerd is game to implement it.

@jennybc jennybc added the area: ui Issues related to UI category. label Dec 9, 2024
@jennybc
Copy link
Member Author

jennybc commented Dec 10, 2024

In the next iteration, it would be good to know for sure if the message can contain Markdown (and it would be really nice if it could).

@juliasilge
Copy link
Contributor

With respect to markdown, we are currently prioritizing compatibility with the rstudioapi package, which expects HTML tags like <b>bold</b> and not markdown.

@jennybc
Copy link
Member Author

jennybc commented Dec 10, 2024

Ah, so then I think we should just add this to the docstring for message.

@softwarenerd softwarenerd self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Issues related to UI category.
Projects
None yet
Development

No branches or pull requests

3 participants