Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Permissions.delete(*permissions) method #339

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: Add Permissions.delete(*permissions) method #339

wants to merge 17 commits into from

Commits on Nov 15, 2024

  1. add Permissions.delete() method

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f737bc6 View commit details
    Browse the repository at this point in the history

  2. add unit tests for permission

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e498165 View commit details
    Browse the repository at this point in the history

  3. Rename Permission.delete to Permission.destroy

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    32e5024 View commit details
    Browse the repository at this point in the history

  4. Rename Permissions.delete to Permissions.destroy

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    85fdc1e View commit details
    Browse the repository at this point in the history

  5. Update test with destroyinng user, group, and permission

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1b50382 View commit details
    Browse the repository at this point in the history

  6. Add check for no permissions to be removed

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1119e31 View commit details
    Browse the repository at this point in the history

  7. Create test_content_item_permissions.py

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a9fbb36 View commit details
    Browse the repository at this point in the history

  8. Update docs

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9eaf38d View commit details
    Browse the repository at this point in the history

  9. Have tests play nicely with each other

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8269629 View commit details
    Browse the repository at this point in the history

  10. Do not remove Permission.destroy(), instead deprecate it (usage in … 

    …existing cookbook)
    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ecdf800 View commit details
    Browse the repository at this point in the history

  11. Remove impossible commented code

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b2cd9d2 View commit details
    Browse the repository at this point in the history

  12. Correct outdated name

    @schloerke
    schloerke committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ba02668 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jonathan Keane <[email protected]>
    @schloerke @jonkeane
    schloerke and jonkeane authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c3261ed View commit details
    Browse the repository at this point in the history

  2. simplify docs. Add note about silently ignoring perms not found

    @schloerke
    schloerke committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2ce66b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Remove deprecated code

    @schloerke
    schloerke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    debb45a View commit details
    Browse the repository at this point in the history

  2. user clearer name

    @schloerke
    schloerke committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    19f25dd View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jonathan Keane <[email protected]>
    @schloerke @jonkeane
    schloerke and jonkeane authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    11e4730 View commit details
    Browse the repository at this point in the history