Add missing struct fields and unimplemented OpenDataset request handler

posit-dev · Nov 26, 2024 · cf00aa6 · cf00aa6
1 parent f86d3e4
commit cf00aa6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/crates/ark/src/data_explorer/column_profile.rs b/crates/ark/src/data_explorer/column_profile.rs
@@ -68,6 +68,7 @@ pub async fn handle_columns_profiles_requests(
     let event = DataExplorerFrontendEvent::ReturnColumnProfiles(ReturnColumnProfilesParams {
         callback_id,
         profiles,
+        error_message: None,
     });
 
     let json_event = serde_json::to_value(event)?;

diff --git a/crates/ark/src/data_explorer/r_data_explorer.rs b/crates/ark/src/data_explorer/r_data_explorer.rs
@@ -522,6 +522,10 @@ impl RDataExplorer {
 
             DataExplorerBackendRequest::GetState => r_task(|| self.r_get_state()),
 
+            DataExplorerBackendRequest::OpenDataset(_) => {
+                return Err(anyhow!("Data Explorer: Not yet supported"));
+            },
+
             DataExplorerBackendRequest::SearchSchema(_) => {
                 return Err(anyhow!("Data Explorer: Not yet supported"));
             },
@@ -873,6 +877,8 @@ impl RDataExplorer {
     fn r_get_state(&self) -> anyhow::Result<DataExplorerBackendReply> {
         let state = BackendState {
             display_name: self.title.clone(),
+            connected: Some(true),
+            error_message: None,
             table_shape: TableShape {
                 num_rows: match self.filtered_indices {
                     Some(ref indices) => indices.len() as i64,