Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the usage instructions modifiable without changing the source of the package #58

Closed
vilim opened this issue Jul 24, 2020 · 7 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@vilim
Copy link
Member

vilim commented Jul 24, 2020

Other people will have different setups. Also a config file for the NI board channels will be needed.

@diegoasua
Copy link
Member

diegoasua commented Jul 24, 2020

Should this be a python file? I can make a PyQt text editor like the popup that can be launched from command line with a key (e.g. sashimi edit)

@vilim
Copy link
Member Author

vilim commented Jul 24, 2020

I think it's good to keep it a markdown file (the editor can be the Qt plain text one). sashimi editinstructions sounds good. Keep in mind that the file then has to be kept in another place (like ~/.config/sashimi/instructions.md), and the hardware config file would be ~/.config/sashimi/hardware.json)

@vigji
Copy link
Member

vigji commented Jul 24, 2020

I would suggest a .conf file and the configparser module for this

@diegoasua
Copy link
Member

I'll dig into how to do this Luigi

@vigji
Copy link
Member

vigji commented Jul 24, 2020

I can draft a demo PR with a .conf file for the channels if you like

@diegoasua
Copy link
Member

If you can draft it I can fill it in thank you!

@diegoasua diegoasua self-assigned this Jul 27, 2020
@diegoasua diegoasua added enhancement New feature or request release priority labels Jul 27, 2020
@diegoasua
Copy link
Member

This is a duplicate of what #124 aims to solve. Therefore closing as it is duplicate

@diegoasua diegoasua added the duplicate This issue or pull request already exists label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants