Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite data by default might be dangerous... #48

Closed
vigji opened this issue Jul 15, 2020 · 5 comments · Fixed by #45
Closed

Overwrite data by default might be dangerous... #48

vigji opened this issue Jul 15, 2020 · 5 comments · Fixed by #45
Labels
enhancement New feature or request

Comments

@vigji
Copy link
Member

vigji commented Jul 15, 2020

A minor mistake in key pressing can screw an entire experiment. Maybe by default if writing in the same location the stack should be saved in original_0? A bit ugly but it's a risk that you don't want to take.

@diegoasua
Copy link
Member

diegoasua commented Jul 15, 2020

It sets the button to orange if you are about to overwrite data and says overwrite. I believe making that double folder would be bad. I can make a popup that says WARNING in red, with fireworks, if you are about to overwrite... Seriously happy to do so

@vigji
Copy link
Member Author

vigji commented Jul 15, 2020

I get all the warning points, but I was this close to press again start experiment by accident after one was finished. If you absolutely don't want to have multiple stacks in one fish folder (it would also be good for stuff like Ot;s experiments with multiple sessions or anatomies though), then yes, warnings and fireworks at least!

@diegoasua
Copy link
Member

diegoasua commented Jul 15, 2020

I'll start working on it. What about a deal. A pop-up will show up when pressing experiment start if you finished an experiment before and you are running a new fish without changing the folder. It will let you either continue or abort (nothing happens, not even experiment is triggered). It is likely that these mistakes happen when you are running the same protocol over many fish. However if you restart the software it is likely that you will have to specify saving folder (if someone messes up here it is definitely their fault for lack of attention)

@vigji
Copy link
Member Author

vigji commented Jul 15, 2020

Fair enough, I think this makes sense!

@diegoasua
Copy link
Member

Succesful merging of PR #45 implements the impossible-to-miss overwrite alert

@diegoasua diegoasua added the enhancement New feature or request label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants