Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgtown/auth 2 #4595

Merged
merged 4 commits into from
May 2, 2024
Merged

dgtown/auth 2 #4595

merged 4 commits into from
May 2, 2024

Conversation

d-g-town
Copy link
Collaborator

@d-g-town d-g-town commented May 1, 2024

  • refactoring main, adding separate authn/z providers
  • address comments

ianedwards
ianedwards approved these changes May 1, 2024
View reviewed changes
dashboard/src/shared/auth/AuthnContext.tsx Outdated Show resolved Hide resolved
dashboard/src/shared/auth/AuthnContext.tsx
}

// Handle case where new user signs up via OAuth and has not set name and company
if (!hasInfo && userId > 9312) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where's this come from out of curiosity

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes from the old code (Main.tsx, line 161)

@d-g-town d-g-town merged commit dbd715a into master May 2, 2024
9 checks passed
@d-g-town d-g-town deleted the dgtown/auth-2 branch May 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianedwards ianedwards ianedwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-g-town @ianedwards