From 5d7eda9f7ff584c28bb062ce5491601f4dd0536e Mon Sep 17 00:00:00 2001 From: omby8888 <160610297+omby8888@users.noreply.github.com> Date: Thu, 29 Aug 2024 18:03:51 +0300 Subject: [PATCH] Added entities deletion by selector test case to pr core checklist (#964) --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 04086c699c..2d4b6c4e1f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -29,6 +29,7 @@ Please leave one option from the following and delete the rest: - [ ] Scheduled resync able to abort existing resync and start a new one - [ ] Tested with at least 2 integrations from scratch - [ ] Tested with Kafka and Polling event listeners +- [ ] Tested deletion of entities that don't pass the selector ### Integration testing checklist @@ -38,7 +39,7 @@ Please leave one option from the following and delete the rest: - [ ] Resync able to update entities - [ ] Resync able to detect and delete entities - [ ] Resync finishes successfully -- [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. +- [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the `examples` folder in the integration directory. - [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved - [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected - [ ] Docs PR link [here](#)