Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quibbles #2

Open
benjifisher opened this issue Nov 25, 2018 · 0 comments
Open

Quibbles #2

benjifisher opened this issue Nov 25, 2018 · 0 comments

Comments

@benjifisher
Copy link

I hope you do not mind these little nit-picks. I would not have noticed them if I had not followed your post closely, and I would not bother asking you to fix them if I did not think that the post is worth the effort.

  • You do not specify a filename for the BlogTeaser component.
  • When you import the BlogTeaser component, you use a CamelCase filename, which is not consistent with the convention for other components.
  • I have never seen the usage "For now, let's suffice to say ...". I think the idiom is "For now, suffice it to say ...". Of course, you could also use "For now, let's just say ...".
  • Inconsistent capitalization: the text mentions DangerouslySetInnerHTML, but the code snippet uses dangerouslySetInnerHTML.
  • Please add a step npm install transliteration --save.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant