Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

droptransfer feature shulkerbox nested and droptransfer bind to doors, problems leading to loss of items #239

Open
thefatwhale opened this issue Sep 5, 2024 · 2 comments
Open

droptransfer feature shulkerbox nested and droptransfer bind to doors, problems leading to loss of items #239

thefatwhale opened this issue Sep 5, 2024 · 2 comments

Comments

@thefatwhale
Copy link

LWC Version (/lwc admin version):

/lwc admin version
Main plugin: 2.4.0

Server version (/version):

/version
This server is running Paper version git-Paper-497 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: d8d54d9 on ver/1.20.4)

Short five word summary of issue:

1 Shulker Box can nested with droptransfer feature.

Detailed description of problem:
To reproduce this.

  1. Place Shulker Box Block on the ground.
  2. use /lwc mode droptransfer select and rightclick to select shulker box.
  3. drop your shulker box, It transfer into shulkerbox, nested.

2 droptransfer can bind non-container protection blocks. And remove item if try to drop items.

  1. Droptransfer can bind to a protection block even no container.
  2. try to drop items, leading to loss items.

To reproduce this.

  1. place a oak trapdoor on ground.
  2. use /lock to protection this trapdoor.
  3. use /lwc mode droptransfer select and right click the trapdoor. to bind
  4. try to drop items use Q, item removed by plugin.

I'm trying to modify this part of the code. with issue #238 together.
@rautamiekka
Copy link

Old Paper version, mod 2.4.0 is for 1.20.6.

thefatwhale added a commit to thefatwhale/LWCX that referenced this issue Sep 6, 2024
@thefatwhale
[Bug fix] See issues [pop4959#238], [pop4959#239] for details.
c91c0ca 
- magnet flag can turn on, on non-container block.
- magnet feature behavior is incorrect with mult container.
- magnet feature behavior is incorrect with furnace-like.

- droptransfer feature can bind with non-container block.
- droptransfer feature cleared item when bind a non-container block.
- droptransfer feature can nested shulker box.
@thefatwhale thefatwhale mentioned this issue Sep 6, 2024
Open
@thefatwhale
Copy link
Author

A pull request is created.

#240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rautamiekka @thefatwhale