Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow splitting display.lua #3

Open
ypujante opened this issue Jun 19, 2020 · 2 comments
Open

Allow splitting display.lua #3

ypujante opened this issue Jun 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ypujante
Copy link
Member

From this thread forum https://www.reasonstudios.com/forum/showpost.php?p=1618219&postcount=6 and @DavidAntliff response, it seems that it would be great if the re-cmake would help in doing that.

I am not sure how exactly, but that is something it would be great to have.

@ypujante ypujante added the enhancement New feature or request label Jun 19, 2020
@ypujante
Copy link
Member Author

@DavidAntliff was suggesting that this could also apply to other lua files (like motherboard_def.lua, info.lua, realtime_controller.lua, display.lua and texts.lua)

@ypujante
Copy link
Member Author

Although not very fancy or flexible, but really easy to implement is to change the various (optional) single arguments to add_re_plugin, like DISPLAY_LUA, to multiple arguments and simply concatenate them in the order provided to generate the final file (and with dependencies, the file can be regenerated automatically if any of the files to concatenate changes).

ex:

add_re_plugin(
  ...
  DISPLAY_LUA ${MY_COMMON_FRAMEWORK}/src/lua/common_display.lua src/lua/display_1.lua src/lua/display_2.lua
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant