-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sort slim results on gene column #2246
Comments
It's probably 2-3 hours work. |
This comment was marked as outdated.
This comment was marked as outdated.
Which order should the rows be when you sort by gene count? Largest count at top or bottom? |
This matches the other places where we can sort by a column of numbers. Refs #2246
I've implemented this with the smallest at the top for now - very easy to change. Most other places where we sort by a column of numbers we use that order, like the literature section of gene pages and on the results pages for things like protein length. There are two different types of slim pages. There is the slim overview: and the pages of slimmed gene results sets: The first case was very simple to implement, but the second case was slightly more involved. If you see an bugs it will likely be in the second case. Let me know if there are problems. This will be on pombase.org in the morning. The nightly update is running a little late because I broke things implementing modification filtering and had to restart. It should be done by 8am UK. Also available on my desktop: https://desktop.kmr.nz/browse-curation/fission-yeast-bp-go-slim-terms |
Now live: |
please! |
Looks good! for both types of pages |
Is it OK that that's inconsistent? |
inconsistent with what? The ones we are most interested in are the annotated bins. Otherwise I need to scroll to the bottom and read it backwards? |
See: #2246 (comment)
So I'm wondering if it's OK to be inconsistent? |
I think this "inconsistency" is OK since the ordering by gene count will serve different purposes:
|
Thanks for the explanation. I agree, they have different purposes so the inconsistency is OK |
OK, thanks. I've re-released with the largest gene count at the top. |
I wondered if this would be easy to do:
It would be nice to be able to rank these by number
The text was updated successfully, but these errors were encountered: