Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to sort slim results on gene column #2246

Closed
ValWood opened this issue Sep 28, 2024 · 13 comments
Closed

Ability to sort slim results on gene column #2246

ValWood opened this issue Sep 28, 2024 · 13 comments
Assignees

Comments

@ValWood
Copy link
Member

ValWood commented Sep 28, 2024

I wondered if this would be easy to do:

It would be nice to be able to rank these by number

Screenshot 2024-09-28 at 12 56 01
@kimrutherford
Copy link
Member

I wondered if this would be easy to do:

It's probably 2-3 hours work.

@ValWood

This comment was marked as outdated.

@kimrutherford
Copy link
Member

Which order should the rows be when you sort by gene count? Largest count at top or bottom?

kimrutherford added a commit that referenced this issue Nov 1, 2024
kimrutherford added a commit that referenced this issue Nov 1, 2024
This matches the other places where we can sort by a column of
numbers.

Refs #2246
@kimrutherford
Copy link
Member

Which order should the rows be when you sort by gene count? Largest count at top or bottom?

I've implemented this with the smallest at the top for now - very easy to change. Most other places where we sort by a column of numbers we use that order, like the literature section of gene pages and on the results pages for things like protein length.

There are two different types of slim pages. There is the slim overview:

and the pages of slimmed gene results sets:

The first case was very simple to implement, but the second case was slightly more involved. If you see an bugs it will likely be in the second case. Let me know if there are problems.

This will be on pombase.org in the morning.

The nightly update is running a little late because I broke things implementing modification filtering and had to restart. It should be done by 8am UK.

Also available on my desktop: https://desktop.kmr.nz/browse-curation/fission-yeast-bp-go-slim-terms

@kimrutherford
Copy link
Member

This will be on pombase.org in the morning.

Now live:
https://dev.pombase.org/browse-curation/fission-yeast-bp-go-slim-terms

@ValWood
Copy link
Member Author

ValWood commented Nov 1, 2024

by gene count? Largest count at top

please!

@ValWood
Copy link
Member Author

ValWood commented Nov 1, 2024

Looks good! for both types of pages

@kimrutherford
Copy link
Member

by gene count? Largest count at top

please!

Is it OK that that's inconsistent?

@ValWood
Copy link
Member Author

ValWood commented Nov 1, 2024

inconsistent with what? The ones we are most interested in are the annotated bins. Otherwise I need to scroll to the bottom and read it backwards?

@kimrutherford
Copy link
Member

inconsistent with what? The ones we are most interested in are the annotated bins. Otherwise I need to scroll to the bottom and read it backwards?

See: #2246 (comment)

I've implemented this with the smallest at the top for now - very easy to change. Most other places where we sort by a column of numbers we use that order, like the literature section of gene pages and on the results pages for things like protein length.

So I'm wondering if it's OK to be inconsistent?

@PCarme
Copy link
Contributor

PCarme commented Nov 1, 2024

I think this "inconsistency" is OK since the ordering by gene count will serve different purposes:

  • For the Literature section, you want the lowest gene counts at the top to see the papers that are specific to the gene you are looking at first, and all the high throughput assays "hidden" at the bottom of the list.
  • For the slims, I think the idea is to see the terms that are the most annotated, so the "most interesting" first.

@ValWood
Copy link
Member Author

ValWood commented Nov 1, 2024

Thanks for the explanation. I agree, they have different purposes so the inconsistency is OK

@kimrutherford
Copy link
Member

OK, thanks.

I've re-released with the largest gene count at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants