-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribution for pathways #1174
Comments
Can you show me an example?
Is "reviewed-by" something that can be stored in Noctua? |
Well I assumed (most likely incorrectly) that they would be exported. They are shown associated with the models on the landing page as "contributors" http://noctua.geneontology.org/workbench/noctua-landing-page/ |
I can ask about this. I guess it would involved the reviewers obtaining a git ID and a Noctua log in though. And I guess they would need to then distinguish between editors and reviewers. I was hoping it could be simpler because we already store the people's detail in Canto locally so we wouldn't run into GDPR issues. We could (presumably) just confirm that they are willing to review and be attributed and then store their name in a config associated with the model ID? |
I had a look. The contributors are available via RDF, at least:
http://noctua.geneontology.org/download/gomodel:66187e4700001573/owl |
That seems like a good feature for Noctua.
Let's have a chat about that. I think if they have to log into Noctua to review, that's the point where they should confirm that they're happy about GDPR issues. |
I opened a ticket about this, but I should have said I'm not expecting them to log in to Noctua. They are reviewing the post-production pathways once they are on dev (I think this is easier) |
I've just spent some time reading up on RDF, OWL and Turtle which I had never done before. For dealing with the GO-CAM data I don't think I can avoid it any more. OBO and GAF files aren't enough. :-) So I think I now know why that snippet above has such odd syntax and how to parse it correctly. I think I might need to learn a bit about SPARQL next so we can query for PomBase models. |
It's a bit painful. The documentation for all these things is very jargony. For example, the RDF docs mention "blank nodes" and they occur in OWL files. This is how they are described - clear as mud!: The blank nodes in an RDF graph are drawn from an infinite set. This set of blank nodes, the set of all RDF URI references and the set of all literals are pairwise disjoint. Otherwise, this set of blank nodes is arbitrary. RDF makes no reference to any internal structure of blank nodes. Given two blank nodes, it is possible to determine whether or not they are the same. |
Oh my gosh. |
Turns out the RDF querying of GO and pathways is going the way of the dodo, so no problem. |
I've had a look the GO-CAM data returned by the GO API and the contributor is included. There's not an obvious place to store the contributor in Chado so I'll need to think about that. Storing the model titles in Chado is already quite a big hack so it might make sense to store the model title and the contributors (and any other model metadata) in a JSON file in SVN rather than Chado. |
Store gene part_of pathway with feature_relationship table. Refs pombase/pombase-chado#1174
I've had a think about this and we can probably use the |
It might help with Chado to have a PB ref for GO-CAMs. Does that make sense? |
Yes I think so. Draft: GO CAMs (Causal Activity Models) are pathway models curated manually by combining standard GO annotations. |
Great, thanks. Can you suggest a title? Is "Causal Activity Model curation" enough? |
"GO-CAM Causal Activity Model curation" |
That's probably the simplest plan, have an SVN file like I've just added a file of PomBase ORCIDs and names which might be useful later:
Also available in the new JSON files (see #1248) {
"key": "contributor",
"value": "https://orcid.org/0000-0001-6330-7526"
},
{
"key": "contributor",
"value": "https://orcid.org/0009-0003-9059-1333"
},
I'm working on that now so we can store the GO-CAM contributors (and later the reviewers) in Chado. |
We now parse the GO-CAM JSON files and pull out the data needed for Chado into a single JSON file. Refs #1174
As a first step, I've updated the script that parses the GO-CAM model JSON files to write a single JSON file containing all the model data needed for loading into Chado:
|
And rename go_cam_pathway feature type to gocam_model. Refs pombase/pombase-chado#1174
We now don't used properties of genes and cvterms to store GO-CAM model IDs and titles. The model contributors and date from the GO-CAM JSON files are now available from the API (/api/v1/dataset/latest/data/gocam/all) Refs pombase/pombase-chado#1174
I've now re-worked how GO-CAMs are stored in Chado to be more flexible. So the contributors and date(*) from the models are now in Chado and can now be displayed on the website or used anywhere else we need them.
We need to decide where/when to display the authors/contributors. Should we show the date?
We now have a way to store reviewers in Chado and to pass that through to the website. I broke last night's load with some of the changes I made yesterday so there was no update. I'll check things working on Saturday morning. |
And we should chat about reviewers. Is this plan OK?:
We could do that very quickly. We'd need to also decide where to display the reviewer name. (And do we have to worry about the GDPR? What a drag) |
This sounds like a reasonable solution. |
To make GO-CAM JSON more consistent. Refs #1174
Should we put the attribution and reviewer name only on the full page GO-CAM pages?: |
I think so |
Something like this?: |
Maybe "Curated by"? |
That makes sense. It will match "Reviewed by" when we add that. I'll change it. |
We can display attribution for pathways because authors are captured in Noctua . I plan to ask the community to review the pathways as we create them. It would be nice if we could store a "reviewed-by" somewhere ....
The text was updated successfully, but these errors were encountered: